Uh oh!
There was an error while loading. Please reload this page.
enh(files): Allow to copy files into same directory - #42889
Merged
Conversation
susnuxforce-pushed
the
fix/copy-in-same-dir
branch
3 times, most recently
from
January 18, 2024 01:53
2034ea9 to
d5427fcComparesusnux
marked this pull request as ready for review
January 18, 2024 11:25
skjnldsv
requested changes
Jan 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
artonge
reviewed
Jan 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
susnuxforce-pushed
the
fix/copy-in-same-dir
branch
from
January 18, 2024 17:27
d5427fc to
6a0d4d6Compareartonge
approved these changes
Jan 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
emoral435
suggested changes
Jan 19, 2024
emoral435
left a comment
Contributor
There was a problem hiding this comment.
Just needs the file part and it LGTM!!
susnuxforce-pushed
the
fix/copy-in-same-dir
branch
2 times, most recently
from
January 19, 2024 19:26
ed6589c to
8d835e1Comparesusnux
commented
Jan 19, 2024
ContributorAuthor
@emoral435 can you check again if that still happens for you? |
emoral435
approved these changes
Jan 19, 2024
emoral435
left a comment
Contributor
There was a problem hiding this comment.
Checked, and it works perfectly for me now :) sorry for being nitpicky!
emoral435
commented
Jan 19, 2024
Contributor
@skjnldsv before we merge this in, it still says that you have requested changes. I'm 99% sure your fine with this, but just to make sure, all the changes now are fine by you, correct? :) |
skjnldsv
approved these changes
Jan 20, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…py-move-action Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
enabled auto-merge
January 20, 2024 14:42
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/copy-in-same-dir
branch
from
January 20, 2024 14:45
8d835e1 to
81925a7Compareskjnldsv
commented
Jan 20, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring back copy to current directory behavior which will clone the file and add a "copy" suffix on the file name.
Checklist