Uh oh!
There was an error while loading. Please reload this page.
fix: always add user to group cache - #42931
Merged
Merged
Conversation
solracsf
requested review from
a team, Altahrim, ArtificialOwl and nfebe
and removed request for
a teamJanuary 18, 2024 12:45
Merged
Altahrim
approved these changes
Mar 12, 2024
This was referenced Mar 14, 2024
Merged
Merged
Merged
Merged
When there is no user in a group, and we add one, it's not added to the group cache. So consecutive call of addUser() and getUsers() is inconsistent. Furthermore, the user cache is never null, so this check is unesserary. Signed-off-by: Hugo Renard <hugo.renard@protonmail.com>
artonge
approved these changes
Mar 26, 2024
come-nc
approved these changes
Mar 26, 2024
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When there is no user in a group, and we add one, it's not added to the group cache. So consecutive call of
addUser()andgetUsers()is inconsistent. Furthermore, the user cache is never null, so this check is unesserary.Checklist