Skip to content

[stable26] fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english - #42935

Closed
backportbot[bot] wants to merge 3 commits into
stable26from
backport/42172/stable26
Closed

[stable26] fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english#42935
backportbot[bot] wants to merge 3 commits into
stable26from
backport/42172/stable26

Conversation

@backportbot

@backportbotbackportbotBot commented Jan 18, 2024

Copy link
Copy Markdown

Backport of #42172

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

…runcated in locales other than english
fixes#18468
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
[skip ci]
@backportbotbackportbotBot added the 3. to review Waiting for reviews label Jan 18, 2024
@backportbotbackportbotBot added this to the Nextcloud 26.0.11 milestone Jan 18, 2024
@blizzzblizzz changed the title [stable26] [stable27] fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english[stable26] fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than englishJan 18, 2024
…runcated in locales other than english
fixes#18468
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
marcelklehr marked this pull request as ready for review January 18, 2024 14:42
@Pytal

Copy link
Copy Markdown
Member

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Comment threadpackage.json
@@ -44,7 +44,7 @@
"@nextcloud/capabilities": "^1.0.4",
"@nextcloud/dialogs": "^4.0.0-beta.2",
"@nextcloud/event-bus": "^3.0.2",
"@nextcloud/files": "^3.0.0-beta.5",
"@nextcloud/files": "^3.0.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change and not allowed for old stable branches

This was referenced Feb 14, 2024
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 22, 2024
@skjnldsv

Copy link
Copy Markdown
Member

Moving to 26.0.13

@skjnldsv
skjnldsv marked this pull request as draft February 29, 2024 10:37
@AltahrimAltahrim mentioned this pull request Mar 21, 2024
7 tasks
@AndyScherzingerAndyScherzinger removed this from the Nextcloud 26.0.13 milestone May 28, 2024
@blizzz

Copy link
Copy Markdown
Member

@marcelklehr do we need it or can we close it?

@marcelklehr

Copy link
Copy Markdown
Member

We can close it, I think.

@blizzzblizzz closed this Jun 21, 2024
@skjnldsv
skjnldsv deleted the backport/42172/stable26 branch December 19, 2024 18:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Pytal@skjnldsv@blizzz@marcelklehr@AndyScherzinger@nextcloud-command