Skip to content

fix(files): fixed aria-desciption logic for last breadcrumb - #42950

Merged
skjnldsv merged 1 commit into
masterfrom
fix/a11y/41895/breadcrumb-fix-for-home-component
Jan 20, 2024
Merged

fix(files): fixed aria-desciption logic for last breadcrumb#42950
skjnldsv merged 1 commit into
masterfrom
fix/a11y/41895/breadcrumb-fix-for-home-component

Conversation

@emoral435

@emoral435emoral435 commented Jan 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Cleaned up the aria-description logic a bit!

Screenshots for the new changes

image

Checklist

@emoral435emoral435 added this to the Nextcloud 29 milestone Jan 18, 2024
@emoral435emoral435 self-assigned this Jan 18, 2024
@emoral435
emoral435force-pushed the fix/a11y/41895/breadcrumb-fix-for-home-component branch from ceb5f77 to fa29df4CompareJanuary 18, 2024 23:50
ShGKme
ShGKme requested changes Jan 18, 2024
View reviewed changes
Comment threadapps/files/src/components/BreadCrumbs.vue Outdated
@emoral435
emoral435force-pushed the fix/a11y/41895/breadcrumb-fix-for-home-component branch 2 times, most recently from dbfbbd0 to ea765cfCompareJanuary 19, 2024 00:52
@Pytal

Pytal commented Jan 19, 2024

Copy link
Copy Markdown
Member

I just checked on master and it is already translated correctly 💡

image

@Pytal

Pytal commented Jan 19, 2024

Copy link
Copy Markdown
Member

Seems @szaimen checked with German where it is not translated so no issue code-wise

@szaimen

szaimen commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Seems @szaimen checked with German where it is not translated so no issue code-wise

indeed, looks like it...

@emoral435

emoral435 commented Jan 19, 2024

Copy link
Copy Markdown
ContributorAuthor

@Pytal@ShGKme I still propose that this PR get merged. Upon checking the master branch, it appears that the last breadcrumb doesn't have that aria-description that we proposed to keep :/

image

This PR still fixes that! Updated the main summary for the PR though

@emoral435
emoral435 requested a review from ShGKmeJanuary 19, 2024 13:40
@PytalPytal changed the title fix(files): fixed home aria-label and desc logicfix(files): fixed home desc logicJan 19, 2024
@Pytal
Pytal requested a review from skjnldsvJanuary 19, 2024 18:50
@emoral435emoral435 changed the title fix(files): fixed home desc logicfix(files): fixed aria-desc logicJan 19, 2024
@emoral435emoral435 changed the title fix(files): fixed aria-desc logicfix(files): fixed aria-desciption logic for last breadcrumbJan 19, 2024
@emoral435

emoral435 commented Jan 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/compile /

@emoral435

This comment was marked as resolved.

Sign in to view
@skjnldsv

skjnldsv commented Jan 20, 2024

Copy link
Copy Markdown
Member

/backport to stable28

@emoral435@skjnldsv
fix(files): fixed home aria-label and desc logic
81057f6
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/a11y/41895/breadcrumb-fix-for-home-component branch from df22929 to 81057f6CompareJanuary 20, 2024 12:05
@skjnldsvskjnldsv removed the 3. to review Waiting for reviews label Jan 20, 2024
@skjnldsvskjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 20, 2024
@skjnldsv
skjnldsv merged commit fd73d3a into masterJan 20, 2024
@skjnldsv
skjnldsv deleted the fix/a11y/41895/breadcrumb-fix-for-home-component branch January 20, 2024 12:21
@backportbotbackportbotBot mentioned this pull request Jan 20, 2024
Merged
2 tasks
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@PytalPytalPytal approved these changes
@susnuxsusnuxAwaiting requested review from susnux
@JuliaKirschenheuterJuliaKirschenheuterAwaiting requested review from JuliaKirschenheuter
@ShGKmeShGKmeAwaiting requested review from ShGKme

Assignees

@emoral435emoral435

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilitybug

Projects

None yet

Milestone

Nextcloud 29

5 participants

@emoral435@Pytal@szaimen@skjnldsv@ShGKme