Uh oh!
There was an error while loading. Please reload this page.
fix(build): Fix OpenAPI diff on non-default specs - #42974
Merged
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
commented
Jan 19, 2024
MemberAuthor
/skjnldsv-backport to stable28 |
provokateurin
enabled auto-merge
January 19, 2024 22:36
bigcat88
approved these changes
Jan 20, 2024
bigcat88
left a comment
Member
There was a problem hiding this comment.
Description for the PR:
Matches files that contain openapi anywhere in the name and end with .json. For example, both api-openapi.json and openapi-version2.json will match.
More flexible, allowing for additional characters in the filename before the .json extension.
nickvergessen
approved these changes
Jan 20, 2024
skjnldsv
commented
Jan 20, 2024
Member
/backport to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Required to also fail on diffs for specs that are not the default one.
Checklist