fix(files): Make the navigation reactive to view changes and show also sub routes as active

[susnux]

Summary

This resolves two issues with the files app navigation:

1. The navigation was not reactive as the currentView is a computed value but all source objects are not reactive (@nextcloud/files Navigation). So to ensure changes to the navigation can be detected the object is made observable.
2. Removed the exact prop on the app navigation as otherwise it will not show all files active if you visited a file like apps/files/files/123.
3. Minor type fixes in Navigation.vue

Screenshots

Before

Pay attention that while the navigation changes the file list does not. Also not that no navigation is active within a subfolder.

vokoscreenNG-2024-01-21_00-54-00.mp4

After

See that navigation works and the file list is updated + also in subfolders the navigation is kept active.

Please note: The current version (video) is shown here: #42992 (comment) )

vokoscreenNG-2024-01-21_00-52-54.mp4

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

/backport to stable28

[skjnldsv]

Removed the exact prop on the app navigation as otherwise it will not show all files active if you visited a file like apps/files/files/123.

Now it does this, which is a regression.
I think we need our custom exact checker 🤔

[susnux]

Now it does this, which is a regression.
I think we need our custom exact checker 🤔

I do not think we need such a complex solution, I think we can go for the moment with just checking the view we are in.
This fixes the initial issue and will not lead to that regression.

I pushed a fix that only disables exact for the files view.

We might later add a exact property to the View entry itself to let them decide, but thats up for discussion in a future iteration(?).

Edit we have another issue with the favorites, the generated route on the navigation did not include the fileid but it was set when clicking the file from the filelist.
So the latest commit fixes this by also settings the fileid param on the route like the filelist does on click (this is also more consistent with the other behavior in files).

[susnux]

Looks like this now:

vokoscreenNG-2024-01-21_20-07-00.mp4

[emoral435]

Overall, love this PR. I'm just getting assigned to more files-related issues for the spring sprint, and my advice was to ping you whenever I have a question or draft a PR, so seeing your code genuinely supports my growth here, and I will def ping you to review my PR's because the code quality here is really good. Just a few comments and nitpicks and this is perfect, I tried it on my local dev env and it also works :)

[skjnldsv]

What I don't get is that it worked before.
v28.0.0 and v28.0.1 doesn't have that reactivity issue.

What broke it in between?

EDIT: git bisect says #42994 broke it
EDIT2: yep, if I revert efaf1ce, it works again

[susnux]

What I don't get is that it worked before.

I wonder how it worked before because that object was never made reactive?

Fixed the regression

[skjnldsv]

I wonder how it worked before because that object was never made reactive?

It's a value from an object, which is passed as a reference, it should be reactive by default.
Something changed with the 2.7.16 update, feel free to try it yourself 🤷

EDIT: this is actually not an issue with vue, but the 5.1.0 release of @nextcloud/dialogs
Downgrading to 5.0.3 fixes the reactivity issue

EDIT2: wrong test, my bad, downgrading vue to 2.7.15 does fix it

[susnux]

/backport to stable28

[ShGKme]

I have /foo/bar/ both favorite. Initially "All favorites" is open

Depending on how I go to the bar, I have different result and selected button on the navigation.

If I go from the files list (All favorites is open), I see no content.

Click from the favorites list	Click from the files list

[susnux]

Depending on how I go to the bar, I have different result and selected button on the navigation.

Resolved this

vokoscreenNG-2024-01-25_12-39-35.mp4

[ShGKme]

Resolved this

It still doesn't fully work for me. It fixes the navigation active, but the content is not displayed.

Try to add some content to the "Bar" folder. It must be listed then Favorites/Bar is open from the navigation.

[susnux]

I think it is unrelated, but another bug. This also happens on master, the problem here is that dir is set to /bar while it should be /foo/bar

[susnux]

@ShGKme pushed a commit that fixes also that issue, you can try again :)

[ShGKme]

Works now 🥳