Skip to content

fix(weather_status): Fix location format for OpenAPI - #42996

Merged
blizzz merged 1 commit into
masterfrom
fix/weather_status/location-format
Jan 22, 2024
Merged

fix(weather_status): Fix location format for OpenAPI#42996
blizzz merged 1 commit into
masterfrom
fix/weather_status/location-format

Conversation

@provokateurin

Copy link
Copy Markdown
Member

Summary

Previously lat and lon were typed as float but they are always string. I fixed that and also fixed the type hierarchy so now all the endpoints use the same base type for locations.

Checklist

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@bigcat88bigcat88 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test, but looking good

@blizzzblizzz mentioned this pull request Jan 22, 2024
@blizzz
blizzz merged commit 90a551d into masterJan 22, 2024
@blizzz
blizzz deleted the fix/weather_status/location-format branch January 22, 2024 09:00
@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@blizzz@bigcat88