Skip to content

fix(apps): Fix type information of app manager - #43045

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/fix-type-info-in-appmanager
Jan 23, 2024
Merged

fix(apps): Fix type information of app manager#43045
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/fix-type-info-in-appmanager

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the return types to the method head (both interface and implementation).

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Please add the return types to the method head (both interface and implementation).

Breaks public API, so not for now

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Context? Is this a regression?

@provokateurin

Copy link
Copy Markdown
Member

Breaks public API, so not for now

Why would it break something? If the data returned matches the type then it just adds additional information?

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Context? Is this a regression?

I noticed the null at some point when stepping with the debugger through the code while looking into migration service.
Did not check for the history or context

Why would it break something?

Apps implementing the interface break.
We can have a look in a follow up but I would not backport that compared to this doc block change

@nickvergessen
nickvergessen merged commit 7f1b980 into masterJan 23, 2024
@nickvergessen
nickvergessen deleted the bugfix/noid/fix-type-info-in-appmanager branch January 23, 2024 10:00
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@provokateurin@ChristophWurst@come-nc