Skip to content

fix: Allow to disable multipart copy on external s3 storage - #43060

Merged
skjnldsv merged 1 commit into
masterfrom
fix/s3-external-multipart-copy
Feb 24, 2024
Merged

fix: Allow to disable multipart copy on external s3 storage#43060
skjnldsv merged 1 commit into
masterfrom
fix/s3-external-multipart-copy

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jan 23, 2024

Copy link
Copy Markdown
Member

Follow up to #41914 (e405437)

As we cannot detect if multipart copy is supported there is a config flag added in the earlier pull request. However for external storages we need to expose this flag so the admin can disable it if needed.

@juliusknorr
juliusknorrforce-pushed the fix/s3-external-multipart-copy branch from 219382d to 0ea4eeeCompareJanuary 23, 2024 18:18
@juliusknorrjuliusknorr added bug 3. to review Waiting for reviews labels Jan 23, 2024
@juliusknorrjuliusknorr added this to the Nextcloud 29 milestone Jan 23, 2024
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

I'll extend this with a global config to not require to change all configs manually.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv
skjnldsvforce-pushed the fix/s3-external-multipart-copy branch from 0ea4eee to d576b8eCompareFebruary 24, 2024 16:11
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 24, 2024
@skjnldsv
skjnldsv merged commit 2ee3e03 into masterFeb 24, 2024
@skjnldsv
skjnldsv deleted the fix/s3-external-multipart-copy branch February 24, 2024 17:30
@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@Altahrim@come-nc@skjnldsv