Skip to content

fix(settings): federation scope menu a11y - #43098

Merged
susnux merged 3 commits into
masterfrom
fix/41903/settings--change-scope-a11y
Jan 25, 2024
Merged

fix(settings): federation scope menu a11y#43098
susnux merged 3 commits into
masterfrom
fix/41903/settings--change-scope-a11y

Conversation

@ShGKme

@ShGKmeShGKme commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

Summary

Use new radio behavior feature from NcActionButton.

  • Remove intermediate FederationControlAction
    • NcActions doesn't fully support intermediate components
    • Fixes the menu role
    • Fixes keyboard navigation - Tab switches to the next UI element
  • Use new type="radio"
    • Adjusts to menuitemradio role
  • Remove custom styles to use new defaults
  • Slightly fix padding on a small additional button
    BeforeAfter
    imageimage

Screenshots

BeforeAfter
imageimage

We also have now the default design for radio menus. See discussion in nextcloud-libraries/nextcloud-vue#4744 (comment)

So I also removed the custom design. cc @nextcloud/designers

Old custom designNew default design
imageimage

Checklist

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

@JuliaKirschenheuterJuliaKirschenheuter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, looks great to me design-wise. :)

@susnux
susnux merged commit 8e9d89a into masterJan 25, 2024
@susnux
susnux deleted the fix/41903/settings--change-scope-a11y branch January 25, 2024 10:41
@JuliaKirschenheuter

Copy link
Copy Markdown
Contributor

/backport to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants

@ShGKme@JuliaKirschenheuter@jancborchardt@susnux@Pytal