Skip to content

fix(tests): Make PostgreSQL unit tests less flacky by ordering - #43099

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/make-postgres-unit-test-less-flacky
Jan 25, 2024
Merged

fix(tests): Make PostgreSQL unit tests less flacky by ordering#43099
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/make-postgres-unit-test-less-flacky

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Summary

Postgres uses a journal file, so if you select a list from DB without ordering it, the order does not have to be FIFO.
Since the test is not about ordering but selecting distinct, it's okay to change the order to configkey (there was only 1 appid selected anyway so sorting by that doesn't do anything).

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Why does this happen only now? I can only assume that before due to the 3 columns Postgres did not use a journal, but since recent additions now being 5 columns it started using it.

@nickvergessen
nickvergessen merged commit 2357bcb into masterJan 25, 2024
@nickvergessen
nickvergessen deleted the bugfix/noid/make-postgres-unit-test-less-flacky branch January 25, 2024 18:55
@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@ChristophWurst@provokateurin