Skip to content

[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions - #43136

Merged
susnux merged 1 commit into
stable27from
jr/fix/trashbin-parse-files-api
Jan 26, 2024
Merged

[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions#43136
susnux merged 1 commit into
stable27from
jr/fix/trashbin-parse-files-api

Conversation

@joshtrichards

@joshtrichardsjoshtrichards commented Jan 25, 2024•
edited by susnux
Loading

Copy link
Copy Markdown
Member

Summary

parseWebdavPermissions was renamed to davParsePermissions in nextcloud-libraries/nextcloud-files#706 but the v27 trashbin was not adapted to it.

TODO

  • ...

Checklist

@joshtrichards

joshtrichards commented Jan 25, 2024

Copy link
Copy Markdown
MemberAuthor

/compile amend

@joshtrichardsjoshtrichards changed the title fix(trashbin) Switch parseWebdavPermissions->davParsePermissions[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissionsJan 25, 2024
@joshtrichardsjoshtrichards mentioned this pull request Jan 25, 2024
Closed
8 tasks
@joshtrichards@nextcloud-command
fix(trashbin) Switch parseWebdavPermissions->davParsePermissions
b76f446
Fixes#43134
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the jr/fix/trashbin-parse-files-api branch from ab1cde0 to b76f446CompareJanuary 25, 2024 22:41
@joshtrichardsjoshtrichards linked an issue Jan 25, 2024 that may be closed by this pull request
[Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files #43134
Closed
8 tasks
@susnux
susnux requested review from a team, nfebe, skjnldsv and sorbaugh and removed request for a teamJanuary 25, 2024 23:20
@susnuxsusnux added this to the Nextcloud 27.1.7 milestone Jan 25, 2024
solracsf
solracsf approved these changes Jan 26, 2024
View reviewed changes

@solracsfsolracsf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works ✅

@susnux
susnux merged commit c7cf447 into stable27Jan 26, 2024
@susnux
susnux deleted the jr/fix/trashbin-parse-files-api branch January 26, 2024 13:36
This was referenced Jan 30, 2024
Closed
Closed
@marcelklehrmarcelklehr mentioned this pull request Feb 1, 2024
Merged
4 tasks
@sistemi-nv

sistemi-nv commented Feb 7, 2024

Copy link
Copy Markdown

I'm a newbie with versioning and GIT, but from what I can understand this fix is still not merged to the Stable27 release.
Because this feature is fundamental for the NC platform, can I ask if it it is planned or possible to make a new 27 release with the fix?
Unluckily the 28 Release has still many bugs and regressions (i.e. Drag'n Drop still broken for Safari, #42366) and, in my experience, is still not usable ...
So I hope for a better 27 :)
Many thanks

@joshtrichards

joshtrichards commented Feb 7, 2024

Copy link
Copy Markdown
MemberAuthor

@sistemi-nv Upcoming v27.1.7 along with the root cause fix via #43259

This was referenced Feb 9, 2024
Closed
Merged
@niendeniende mentioned this pull request Mar 26, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsfsolracsfsolracsf approved these changes
@nfebenfebenfebe approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: filesregression

Projects

None yet

Milestone

Nextcloud 27.1.7

Development

Successfully merging this pull request may close these issues.

[Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files

5 participants

@joshtrichards@sistemi-nv@solracsf@nfebe@susnux