Skip to content

fix(files_sharing): Return focus to trigger element on sharing details close - #43137

Merged
Pytal merged 2 commits into
masterfrom
fix/a11y/sharing-details-focus
Jan 26, 2024
Merged

fix(files_sharing): Return focus to trigger element on sharing details close#43137
Pytal merged 2 commits into
masterfrom
fix/a11y/sharing-details-focus

Conversation

@Pytal

@PytalPytal commented Jan 26, 2024

Copy link
Copy Markdown
Member

Summary

  • Switch v-if to v-show to preserve same instance of return focus element instead of mounting a new element on close
  • Return focus to triggering element

Checklist

@PytalPytal added this to the Nextcloud 29 milestone Jan 26, 2024
@PytalPytal self-assigned this Jan 26, 2024
@Pytal

Copy link
Copy Markdown
MemberAuthor

Tip: Hide whitespace 😉

…s close
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the fix/a11y/sharing-details-focus branch from ffebd2b to e6802d2CompareJanuary 26, 2024 19:24
@Pytal

Copy link
Copy Markdown
MemberAuthor

/backport 22ab251 to stable28

@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2024
@Pytal
Pytal enabled auto-merge January 26, 2024 19:27
@Pytal
Pytal merged commit 01520d5 into masterJan 26, 2024
@Pytal
Pytal deleted the fix/a11y/sharing-details-focus branch January 26, 2024 19:53
@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishaccessibilitybugfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal@susnux@nfebe@emoral435