Skip to content

fix(files): disable Unshare until proper fix - #43152

Merged
skjnldsv merged 2 commits into
masterfrom
fix/unshare
Jan 27, 2024
Merged

fix(files): disable Unshare until proper fix#43152
skjnldsv merged 2 commits into
masterfrom
fix/unshare

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jan 26, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Until we fix it for 28.0.3, it's safer to use the Delete wording

fix#43130

@skjnldsvskjnldsv added this to the Nextcloud 28.0.2 milestone Jan 26, 2024
@skjnldsvskjnldsv self-assigned this Jan 26, 2024
@skjnldsv
skjnldsv requested review from a team, nfebe, sorbaugh, susnux and szaimen and removed request for a teamJanuary 26, 2024 17:12
szaimen
szaimen reviewed Jan 26, 2024
View reviewed changes
Comment threadapps/files/src/actions/deleteAction.ts Outdated
@nickvergessen

This comment was marked as resolved.

Sign in to view
@skjnldsv
fix(files): disable Unshare until proper fix
d06ed4d
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
chore(assets): Recompile assets
1ffb13c
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented Jan 27, 2024

Copy link
Copy Markdown
MemberAuthor

/backport! d06ed4d to stable28

@backportbotbackportbotBot mentioned this pull request Jan 27, 2024
Merged
1 task
szaimen
szaimen reviewed Jan 27, 2024
View reviewed changes
Comment threadapps/files/src/actions/deleteAction.ts
@skjnldsv
skjnldsv requested a review from szaimenJanuary 27, 2024 12:10
szaimen
szaimen approved these changes Jan 27, 2024
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then but didnt test

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2024
@skjnldsv
skjnldsv merged commit b6f64cb into masterJan 27, 2024
@skjnldsv
skjnldsv deleted the fix/unshare branch January 27, 2024 12:23
@skjnldsvskjnldsv mentioned this pull request Jan 30, 2024
Merged
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@szaimenszaimenszaimen approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: filesregression

Projects

None yet

Milestone

Nextcloud 28.0.2

Development

Successfully merging this pull request may close these issues.

[Bug]: Contents inside shared directory can be "Unshared" but are effectively deleted

4 participants

@skjnldsv@nickvergessen@susnux@szaimen