Uh oh!
There was an error while loading. Please reload this page.
[stable28] fix: added a label element to the NcSelect in update settings - #43158
Merged
Conversation
emoral435
commented
Jan 29, 2024
Contributor
/compile amend/ |
emoral435
marked this pull request as ready for review
January 29, 2024 13:38
Signed-off-by: Eduardo Morales <emoral435@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> [skip ci]
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435force-pushed
the
backport/43094/stable28
branch
from
January 29, 2024 14:33
cef7ae9 to
f59ef7bCompareemoral435
approved these changes
Jan 29, 2024
Pytal
commented
Jan 30, 2024
Member
Bot 🤖 left some checkboxes to check off @emoral435 :) |
Contributor
@Pytal Thank you for the heads up! I should have left a comment explaining the compile commits I added. Everything is compiled correctly with this PR, the number of files being different just comes from different compiling of unsupported-browser js files, but this one just has the changed file, and the associated 2 compiled JS files EDIT: I did now change the description for the PR now to reflect that any issues have been resolved 👍 |
Pytal
approved these changes
Jan 30, 2024
Pytal
commented
Jan 30, 2024
Member
Thanks @emoral435! |
susnux
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #43094
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
[skip ci]tagLearn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.