Skip to content

[stable28] Move modal outside of the Version component. - #43167

Merged
susnux merged 2 commits into
stable28from
backport/43084/stable28
Feb 2, 2024
Merged

[stable28] Move modal outside of the Version component.#43167
susnux merged 2 commits into
stable28from
backport/43084/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Jan 27, 2024

Copy link
Copy Markdown

Backport of #43084

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@emoral435

Copy link
Copy Markdown
Contributor

/compile amend/

@artonge
artonge marked this pull request as ready for review January 30, 2024 11:09
@artonge

Copy link
Copy Markdown
Collaborator

@emoral435 next time, feel free to check the checkbox in the main comment, and to set the PR as ready to review ;).
Let's wait until 28 unfreeze, and I'll handle the compilation and merging :).

@emoral435

Copy link
Copy Markdown
Contributor

@artonge Gotcha! My bad 😓

@JuliaKirschenheuter
JuliaKirschenheuterforce-pushed the backport/43084/stable28 branch 2 times, most recently from d489775 to 888d591CompareFebruary 1, 2024 19:01
@JuliaKirschenheuter

Copy link
Copy Markdown
Contributor

/compile amend /

@JuliaKirschenheuter

Copy link
Copy Markdown
Contributor

/compile amend /

@JuliaKirschenheuter

Copy link
Copy Markdown
Contributor

/compile amend /

This is for accessibility, to have the NcListItem (<li>) as a direct child of the <ul>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux disabled auto-merge February 2, 2024 15:07
@susnux
susnux merged commit 5e22ee1 into stable28Feb 2, 2024
@susnux
susnux deleted the backport/43084/stable28 branch February 2, 2024 15:07
@skjnldsvskjnldsv mentioned this pull request Feb 14, 2024
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@emoral435@artonge@JuliaKirschenheuter@susnux@blizzz@nextcloud-command