Uh oh!
There was an error while loading. Please reload this page.
feat(files): ask for confirm if deleting 5 items or more - #43231
Merged
Conversation
skjnldsv
requested review from
nfebe and sorbaugh
and removed request for
a teamJanuary 31, 2024 09:12
artonge
approved these changes
Jan 31, 2024
Uh oh!
There was an error while loading. Please reload this page.
skjnldsvforce-pushed
the
feat/warn-batch-delete
branch
2 times, most recently
from
January 31, 2024 10:54
ac49716 to
672faf3Compareskjnldsvforce-pushed
the
fix/sharing-delee-leave-share
branch
2 times, most recently
from
January 31, 2024 10:59
01c9425 to
88ec1dcCompareskjnldsvforce-pushed
the
fix/sharing-delee-leave-share
branch
from
February 5, 2024 16:07
88ec1dc to
6309b59Comparesusnux
approved these changes
Feb 5, 2024
szaimen
approved these changes
Feb 5, 2024
szaimen
left a comment
Contributor
There was a problem hiding this comment.
LGTM from design perspective :)
skjnldsvforce-pushed
the
fix/sharing-delee-leave-share
branch
from
February 6, 2024 16:44
6309b59 to
ca61b11Compareskjnldsvforce-pushed
the
feat/warn-batch-delete
branch
from
February 7, 2024 09:29
3dd519f to
bdd0c19Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
feat/warn-batch-delete
branch
from
February 7, 2024 10:13
bdd0c19 to
1db40e9Compare Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#32011
Needs #43217
@nextcloud/designers