Uh oh!
There was an error while loading. Please reload this page.
fix(files): drag leave detection on safari - #43330
Merged
Merged
Conversation
skjnldsv
requested review from
emoral435, nfebe and szaimen
and removed request for
a teamFebruary 4, 2024 13:10
skjnldsv
commented
Feb 4, 2024
MemberAuthor
/backport to stable28 |
8 tasks
susnux
approved these changes
Feb 4, 2024
susnux
left a comment
Contributor
There was a problem hiding this comment.
I can not verify this fixes the issue (I have no access to Apple devices), but the code makes sense as it seems to be related to this long standing WebKit bug where relatedTarget is unset: https://bugs.webkit.org/show_bug.cgi?id=66547
(Feels like Safari is the new IE).
Uh oh!
There was an error while loading. Please reload this page.
nfebe
approved these changes
Feb 4, 2024
skjnldsv
commented
Feb 4, 2024
MemberAuthor
You and me both 😅🥲 |
skjnldsv
commented
Feb 4, 2024
MemberAuthor
/compile rebase-amend / |
skjnldsv
enabled auto-merge
February 4, 2024 20:29
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
fix/safari-drag-drop
branch
from
February 4, 2024 20:53
7e01e0b to
9c2dc4aComparesusnux
commented
Feb 4, 2024
Contributor
Thats new? Nice! |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#43135