Skip to content

feat: Migrate LinkReferenceProvider to OCP - #43355

Merged
kyteinsky merged 1 commit into
masterfrom
feat/ocp-link-reference-provider
Feb 15, 2024
Merged

feat: Migrate LinkReferenceProvider to OCP#43355
kyteinsky merged 1 commit into
masterfrom
feat/ocp-link-reference-provider

Conversation

@kyteinsky

@kyteinskykyteinsky commented Feb 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This would be useful to eleminate the need for using this OC class
when an app dev wants to implement a custom reference provider
for the web client but wants to fall back on opengraph for mobile
clients.

Checklist

@kyteinsky

kyteinsky commented Feb 5, 2024

Copy link
Copy Markdown
ContributorAuthor

It could've been an abstract class in OCP but that would interfere with ADiscoverableReferenceProvider.php so that idea was dropped.
Please squash before merge. The two commits are separated for ease of review only.

@kyteinsky
kyteinskyforce-pushed the feat/ocp-link-reference-provider branch 3 times, most recently from a3a84cb to eee7c0eCompareFebruary 6, 2024 06:35
julien-nc
julien-nc requested changes Feb 14, 2024
View reviewed changes

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

Then 👍 💙

Comment threadlib/private/Collaboration/Reference/LinkReferenceProvider.php Outdated
@kyteinsky
kyteinskyforce-pushed the feat/ocp-link-reference-provider branch 2 times, most recently from c6629c8 to 4996970CompareFebruary 14, 2024 10:58
@juliusknorrjuliusknorr added this to the Nextcloud 29 milestone Feb 14, 2024
@juliusknorr

juliusknorr commented Feb 14, 2024

Copy link
Copy Markdown
Member

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh

@kyteinsky

kyteinsky commented Feb 14, 2024

Copy link
Copy Markdown
ContributorAuthor

there are a lot of changed hashes in the apps. Should that be included in the commit?

apps/admin_audit/composer/composer/installed.php
- 'reference' => 'b1797842784b250fb01ed5e3bf130705eb94751b',+ 'reference' => '49969705de01aff43cf2e6b662e5c96bd48a3b27',

@juliusknorr

juliusknorr commented Feb 14, 2024

Copy link
Copy Markdown
Member

Just the ones updating the class paths should be enough I think

@kyteinsky
feat: Migrate LinkReferenceProvider to OCP
7329b83
This would be useful to eleminate the need for using this OC class
when an app dev wants to implement a custom reference provider
for the web client but wants to fall back on opengraph for mobile
clients.
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@kyteinsky
kyteinskyforce-pushed the feat/ocp-link-reference-provider branch from 4996970 to 7329b83CompareFebruary 14, 2024 12:52
@kyteinsky
kyteinsky merged commit c83a657 into masterFeb 15, 2024
@kyteinsky
kyteinsky deleted the feat/ocp-link-reference-provider branch February 15, 2024 05:56
@welcome

welcomeBot commented Feb 15, 2024

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@nickvergessennickvergessen mentioned this pull request Feb 15, 2024
Merged
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@julien-ncjulien-ncjulien-nc approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@kyteinsky@juliusknorr@julien-nc