Uh oh!
There was an error while loading. Please reload this page.
fix(settings): focus on federation scope after dialog - #43358
Merged
JuliaKirschenheuter merged 3 commits intoFeb 6, 2024
Merged
fix(settings): focus on federation scope after dialog#43358JuliaKirschenheuter merged 3 commits into
JuliaKirschenheuter merged 3 commits into
Conversation
ShGKme
requested review from
JuliaKirschenheuter, Pytal, emoral435, susnux and szaimenFebruary 5, 2024 14:48
ShGKme
commented
Feb 5, 2024
ContributorAuthor
/backport to stable28 |
ShGKme
commented
Feb 5, 2024
| :clearable="false" | ||
| :options="visibilityOptions" | ||
| :value="visibilityObject" | ||
| label-outside |
JuliaKirschenheuter
approved these changes
Feb 5, 2024
JuliaKirschenheuter
left a comment
Contributor
There was a problem hiding this comment.
works well! Thank you!
Pytal
reviewed
Feb 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ShGKmeforce-pushed
the
fix/settings--focus-on-federation-scope-after-dialog
branch
from
February 5, 2024 19:43
680d45c to
db16ee8ComparePytal
approved these changes
Feb 5, 2024
emoral435
approved these changes
Feb 5, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKmeforce-pushed
the
fix/settings--focus-on-federation-scope-after-dialog
branch
from
February 6, 2024 09:47
db16ee8 to
18a3739CompareShGKme
commented
Feb 6, 2024
ContributorAuthor
Rebased onto master |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKmeforce-pushed
the
fix/settings--focus-on-federation-scope-after-dialog
branch
from
February 6, 2024 10:18
18a3739 to
6a7fc2cCompareJuliaKirschenheuter
deleted the
fix/settings--focus-on-federation-scope-after-dialog
branch
February 6, 2024 12:25
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NcActionsreturns focus to the trigger button by default. However, on the federation scope menu, changing the scope triggers a password confirmation dialog which then loses the focus.Focusing manually after change.
Probably, we should also have
setReturnFocuson password confirmation dialog.Checklist