Skip to content

feature(files) : Give a hint that names starting with dots might be hidden - #43366

Closed
arublov wants to merge 1 commit into
nextcloud:masterfrom
arublov:feature/confirmation-when-name-with-dots
Closed

feature(files) : Give a hint that names starting with dots might be hidden#43366
arublov wants to merge 1 commit into
nextcloud:masterfrom
arublov:feature/confirmation-when-name-with-dots

Conversation

@arublov

Copy link
Copy Markdown
Member

Checklist

Before:
The file name is changed with dots at the beginning without confirmation.

After:
Now when changing a file name with a dot/s at the beginning, a confirmation will pop up first to warn the user that the file can be hidden if the name is changed.

Screenshot 2024-02-05 at 20 57 29

@solracsfsolracsf changed the title feature(files) : When creating a new folder give a hint that folder names starting with dots might be hidden #21609feature(files) : Give a hint that names starting with dots might be hiddenFeb 5, 2024
@solracsf
solracsf requested a review from susnuxFebruary 9, 2024 08:42
@solracsfsolracsf added the 3. to review Waiting for reviews label Feb 9, 2024
@solracsfsolracsf added this to the Nextcloud 29 milestone Feb 9, 2024
@susnux

susnux commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

This might annoy a lot of users because it is shown everytime you rename such a file, especially if you know what you are doing.

So cc @jancborchardt for UX

@ChristophWurst

Copy link
Copy Markdown
Member

As an alternative we could use something like a tooltip. It warns but doesn't get into your way. What do you think?

@jancborchardt

Copy link
Copy Markdown
Member

Yup, would agree with @ChristophWurst’s suggestion of a tooltip. Does this work @arublov@susnux?

@ChristophWurst

Copy link
Copy Markdown
Member

Apparently the dialogue for new files now looks like this:

image

This could be enhanced by a https://nextcloud-vue-components.netlify.app/#/Components/NcNoteCard with type warning right under/over the filename input.

@arublov

arublov commented Feb 19, 2024

Copy link
Copy Markdown
MemberAuthor

Apparently the dialogue for new files now looks like this:

image

This could be enhanced by a https://nextcloud-vue-components.netlify.app/#/Components/NcNoteCard with type warning right under/over the filename input.

Yes, I already tried to implement with NcNoteCard, but if you want to rename a folder/file, it happens:

Screenshot 2024-02-19 at 4 59 13 PM

…ames starting with dots might be hidden nextcloud#21609
Signed-off-by: Andrii Rublov <airublev@outlook.com>
@arublov
arublovforce-pushed the feature/confirmation-when-name-with-dots branch from 35e5341 to 43212e8CompareFebruary 19, 2024 16:02
@arublov

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst / @jancborchardt , If I do like this for renaming folders/files? The NcNoteCard will appear to the right of the input.

Screenshot 2024-02-19 at 5 25 25 PM

@arublovarublov self-assigned this Feb 28, 2024
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsvskjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
@joshtrichardsjoshtrichards added the hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. label Oct 2, 2024
@marcoambrosini

marcoambrosini commented Oct 3, 2024

Copy link
Copy Markdown
Member

About renaming warning: I think the dialog is the way to go, we just need a never show this again checkbox. This type of warning doesn't work well in a tooltip, and for most users it's actually good to break the flow be very clear about the fact that the file/folder is about to be hidden.

@blizzzblizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzzblizzz mentioned this pull request Jan 29, 2025
1 task
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
@susnux

Copy link
Copy Markdown
Contributor

About renaming warning: I think the dialog is the way to go, we just need a never show this again checkbox. This type of warning doesn't work well in a tooltip, and for most users it's actually good to break the flow be very clear about the fact that the file/folder is about to be hidden.

You can take the warn about changed file extension as an example on how to do the "never again" checkbox

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressfeature: fileshotspot: filename handlingFilenames - invalid, portable, blacklisting, etc.staleTicket or PR with no recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When creating a new folder give a hint that folder names starting with dots might be hidden

9 participants

@arublov@susnux@ChristophWurst@jancborchardt@marcoambrosini@joshtrichards@blizzz@solracsf@skjnldsv