Skip to content

fix: added last two places for aria-labels on setting icons - #43369

Merged
Pytal merged 1 commit into
masterfrom
fix/a11y/42855/add-last-two-aria-labels-for-icons
Feb 6, 2024
Merged

fix: added last two places for aria-labels on setting icons#43369
Pytal merged 1 commit into
masterfrom
fix/a11y/42855/add-last-two-aria-labels-for-icons

Conversation

@emoral435

@emoral435emoral435 commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

Summary

After review, there was two places within the list mentioned in the original issue that still need to have their aria-label added. These places are places that still need to be translated to Vue, but for now, they will have their aria-label added here!

setttings/adminsettings/admin/overview
imageimage

TODO

  • Add area label to these sections...
    • index.php/settings/admin
    • index.php/settings/admin/overview

Checklist

@emoral435

Copy link
Copy Markdown
ContributorAuthor

/backport 4f5880f to stable28

Comment threadapps/settings/templates/settings/admin/overview.php Outdated
@emoral435
emoral435force-pushed the fix/a11y/42855/add-last-two-aria-labels-for-icons branch 2 times, most recently from b1fb903 to f654635CompareFebruary 6, 2024 13:55
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435
emoral435force-pushed the fix/a11y/42855/add-last-two-aria-labels-for-icons branch from f654635 to 05d5546CompareFebruary 6, 2024 14:42
@Pytal
Pytal disabled auto-merge February 6, 2024 18:45
@Pytal

Pytal commented Feb 6, 2024

Copy link
Copy Markdown
Member

Cypress unrelated

@Pytal
Pytal merged commit 2db24f5 into masterFeb 6, 2024
@Pytal
Pytal deleted the fix/a11y/42855/add-last-two-aria-labels-for-icons branch February 6, 2024 18:45
@backportbot

Copy link
Copy Markdown

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/43369/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 4f5880f9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43369/stable28

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@Pytal

Pytal commented Feb 6, 2024

Copy link
Copy Markdown
Member

/backport to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsaccessibilitybug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@emoral435@Pytal@JuliaKirschenheuter@ShGKme