Skip to content

Use AccountPlusIcon in broadcrombs - #43433

Merged
szaimen merged 1 commit into
masterfrom
enh/40202/use-correct-icon
Feb 8, 2024
Merged

Use AccountPlusIcon in broadcrombs#43433
szaimen merged 1 commit into
masterfrom
enh/40202/use-correct-icon

Conversation

@szaimen

@szaimenszaimen commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Close#40202
Close#42502
Supercedes #42502

BeforeAfter
imageimage
For my own testing
docker run -it --rm ^
--name nextcloud-easy-test1 ^
-p 8444:443 ^
-e SERVER_BRANCH=enh/40202/use-correct-icon ^
-e COMPILE_SERVER=1 ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimenszaimen added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels Feb 7, 2024
@szaimenszaimen added this to the Nextcloud 29 milestone Feb 7, 2024
@szaimen
szaimenforce-pushed the enh/40202/use-correct-icon branch 2 times, most recently from 6e97ea8 to e91fdadCompareFebruary 7, 2024 13:15
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 7, 2024
@szaimen
szaimen marked this pull request as ready for review February 7, 2024 13:25
@szaimenszaimen mentioned this pull request Feb 7, 2024
5 tasks

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @szaimen! Only one remark: The opacity is there to give a slight indication about the shared state, but maybe we can do it with the same colors as in the file list instead? (color-main-text and color-primary)

@szaimen
szaimenforce-pushed the enh/40202/use-correct-icon branch 2 times, most recently from 162fb15 to bac1b13CompareFebruary 7, 2024 14:08
@szaimen

Copy link
Copy Markdown
ContributorAuthor

Nice @szaimen! Only one remark: The opacity is there to give a slight indication about the shared state, but maybe we can do it with the same colors as in the file list instead? (color-main-text and color-primary)

Should be fixed now :)

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test the code but seems good

@szaimen

This comment was marked as resolved.

@szaimen
szaimen enabled auto-merge February 7, 2024 19:08
@nextcloud-command
nextcloud-commandforce-pushed the enh/40202/use-correct-icon branch from bac1b13 to 7981bf8CompareFebruary 7, 2024 19:14
@szaimen

This comment was marked as resolved.

@skjnldsv

Copy link
Copy Markdown
Member

/compile rebase /

this does NOT ignore conflicts

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/compile rebase /

this does NOT ignore conflicts

Yeah, figured that out already 😅😥

@szaimen
szaimenforce-pushed the enh/40202/use-correct-icon branch from 7981bf8 to 0dbbdeaCompareFebruary 8, 2024 09:42
@szaimen

This comment was marked as resolved.

@skjnldsv
skjnldsvforce-pushed the enh/40202/use-correct-icon branch from 0dbbdea to a183a23CompareFebruary 8, 2024 10:01
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 8, 2024
@szaimen
szaimen merged commit d247d35 into masterFeb 8, 2024
@szaimen
szaimen deleted the enh/40202/use-correct-icon branch February 8, 2024 10:49
@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable28

artonge pushed a commit that referenced this pull request Feb 8, 2024
@blizzzblizzz mentioned this pull request Mar 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adjust icon of shared state in broadcrumb

4 participants

@szaimen@skjnldsv@jancborchardt@nimishavijay