Skip to content

Cache path by id - #43471

Merged
icewind1991 merged 3 commits into
masterfrom
cache-path-by-id
Mar 5, 2024
Merged

Cache path by id#43471
icewind1991 merged 3 commits into
masterfrom
cache-path-by-id

Conversation

@icewind1991

@icewind1991icewind1991 commented Feb 9, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Cache fileid to path mapping.

The fact that a single fileid can have multiple paths complicates attampts to cache this information, however since most usages of getById only use a single item of the result, and always the same one (whether or not this is correct for that usage is another question 🙈). We can provide a new api that only returns a single result which makes caching easier.

We can get away with using a local cache without doing any active cache invalidation by checking that the node at the path we cached still has the correct fileid.

  • add getFirstNodeById to get a single node for id regardless of how many nodes with that id the user has
  • switch over all calls to getById that always use the first node to the new api
  • add caching to getFirstNodeById

I would recommend reviewing this PR commit-by-commit as most of the changes by LOC are mechanical changes to adjust to the new api.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 9, 2024
View reviewed changes
Comment threadcore/Command/Preview/Generate.php Fixed
Comment threadlib/private/DirectEditing/Manager.php Fixed
Comment threadapps/dav/lib/Connector/Sabre/FilesReportPlugin.php Fixed
Comment threadapps/dav/lib/Direct/DirectFile.php Fixed
Comment threadapps/dav/lib/SystemTag/SystemTagsRelationsCollection.php Fixed
Comment threadapps/dav/lib/SystemTag/SystemTagsRelationsCollection.php Fixed
Comment threadapps/federatedfilesharing/lib/FederatedShareProvider.php Fixed
Comment threadapps/files_trashbin/lib/Trash/LegacyTrashBackend.php Fixed
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 9, 2024
View reviewed changes
Comment threadapps/dav/lib/SystemTag/SystemTagsRelationsCollection.php Fixed
@icewind1991
icewind1991force-pushed the cache-path-by-id branch 2 times, most recently from ed9cc7d to a2846beCompareFebruary 9, 2024 10:58
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 9, 2024
View reviewed changes
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php Fixed
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php Fixed
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php Fixed
Comment threadapps/files_sharing/lib/SharedStorage.php Fixed
@icewind1991
icewind1991force-pushed the cache-path-by-id branch 3 times, most recently from 6baf20a to 57e7266CompareFebruary 16, 2024 11:23
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 16, 2024
View reviewed changes
Comment threadlib/private/Files/Node/Root.php Fixed
Comment threadlib/private/Files/Node/Root.php Fixed
@icewind1991
icewind1991force-pushed the cache-path-by-id branch 2 times, most recently from 0a36121 to 68ad797CompareFebruary 16, 2024 12:03
@icewind1991
icewind1991 marked this pull request as ready for review February 16, 2024 12:57
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, blizzz and nfebe and removed request for a teamFebruary 16, 2024 12:57
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Feb 16, 2024
come-nc
come-nc reviewed Feb 19, 2024
View reviewed changes
Comment threadlib/private/Share20/Share.php Outdated
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 23, 2024
come-nc
come-nc approved these changes Feb 27, 2024
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment threadlib/private/Files/Node/LazyFolder.php Outdated
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 27, 2024
View reviewed changes
Comment threadlib/private/Share20/Share.php Fixed
@icewind1991
icewind1991force-pushed the cache-path-by-id branch 2 times, most recently from dbb9170 to 3dfef53CompareFebruary 29, 2024 15:52
@icewind1991
feat: add interface to get only a single node by id instead of all no…
4d110c1
…des for the id
this should be enough in most(?) cases and makes efficient implementation and caching easier
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
perf: switch places that always use the first getById result to getFi…
e7a7b4a
…rstNodeById
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
perf: cache path by id to speedup getting nodes by id
a9ee278
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added 3. to review Waiting for reviews performance 🚀 and removed 2. developing Work in progress labels Mar 5, 2024
@icewind1991
icewind1991 merged commit fd4ca13 into masterMar 5, 2024
@icewind1991
icewind1991 deleted the cache-path-by-id branch March 5, 2024 16:26
@blizzzblizzz mentioned this pull request Mar 7, 2024
Merged
@joshtrichardsjoshtrichards mentioned this pull request Apr 2, 2024
Closed
9 tasks
@icewind1991icewind1991 mentioned this pull request Jun 20, 2024
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 9, 2024
Closed
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@blizzzblizzzAwaiting requested review from blizzzblizzz is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@artongeartongeAwaiting requested review from artonge

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@Altahrim@github-advanced-security@come-nc@skjnldsv