Uh oh!
There was an error while loading. Please reload this page.
get child ids for folder in a separate query during move - #43531
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, blizzz and nfebe
and removed request for
a teamFebruary 12, 2024 15:17
blizzz
approved these changes
Feb 12, 2024
| throw $e; | ||
| } | ||
| } else { | ||
| $this->connection->beginTransaction(); |
Member
There was a problem hiding this comment.
It does not have a catch and rollback in the current implementation, it might be worth to add it? (optionally)
icewind1991force-pushed
the
cache-move-select-children
branch
from
March 7, 2024 15:55
0f493e7 to
0bbc355Compare8 tasks
This was referenced Mar 12, 2024
Merged
Merged
Merged
icewind1991force-pushed
the
cache-move-select-children
branch
from
May 22, 2024 13:46
0bbc355 to
dddf6caCompareChristophWurst
approved these changes
Jun 12, 2024
ChristophWurst
commented
Jun 12, 2024
Member
Conflicts |
ChristophWurst
commented
Jun 12, 2024
Member
/backport to stable29 |
ChristophWurst
commented
Jun 12, 2024
Member
/backport to stable28 |
ChristophWurst
commented
Jun 12, 2024
Member
/backport to stable27 |
blizzz
commented
Jun 12, 2024
Member
conflicts |
Signed-off-by: Robin Appelman <robin@icewind.nl>
blizzzforce-pushed
the
cache-move-select-children
branch
from
June 13, 2024 08:40
dddf6ca to
082c6c6Compare
This was referenced Jun 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help reduce lock contention and hopefully resolve some deadlock issues with concurrent moves.