Skip to content

minor syntax update - #43534

Merged
skjnldsv merged 2 commits into
masterfrom
enh/noid/log-mnor-syntax-update
Mar 16, 2024
Merged

minor syntax update#43534
skjnldsv merged 2 commits into
masterfrom
enh/noid/log-mnor-syntax-update

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Feb 12, 2024

Copy link
Copy Markdown
Member

Some small minor syntax update.

I have currently no idea how we can manage this FIXME:

// FIXME: Add this for backwards compatibility, should be fixed at some point probably
if ($config === null) {
$this->config = \OC::$server->getSystemConfig();
}

It comes from a 9 years old commit e79c255
🫂 @MorrisJobke

2 solutions:

  • removing the code and the null type of $config
  • or removing the FIXME comment line.

@ArtificialOwlArtificialOwl added the 2. developing Work in progress label Feb 12, 2024
@ArtificialOwlArtificialOwl added this to the Nextcloud 29 milestone Feb 12, 2024
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/leave-log-early-if-no-crash-reporter branch from bf68594 to 18a6b62CompareFebruary 12, 2024 18:17
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/log-mnor-syntax-update branch 2 times, most recently from dfab91a to 2455381CompareFebruary 12, 2024 19:18
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/leave-log-early-if-no-crash-reporter branch 4 times, most recently from bf6cb92 to 2232753CompareFebruary 14, 2024 15:06
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/log-mnor-syntax-update branch from 2455381 to de5a1cfCompareFebruary 14, 2024 17:44
Base automatically changed from enh/noid/leave-log-early-if-no-crash-reporter to masterFebruary 23, 2024 20:56
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/log-mnor-syntax-update branch 2 times, most recently from 8117def to 9148d4cCompareFebruary 29, 2024 14:45
@ArtificialOwlArtificialOwl added 3. to review Waiting for reviews php Pull requests that update Php code and removed 2. developing Work in progress labels Feb 29, 2024
@MorrisJobke

Copy link
Copy Markdown
Member
  • or removing the FIXME comment line.

That's a nice one 😆

  • removing the code and the null type of $config

That makes sense, but check if some initializing code passes in null as well. I guess that was my lazy self back then. I didn't wanted to check all the callers 🙈

@ArtificialOwl

Copy link
Copy Markdown
MemberAuthor

Hello Sir !

Hardcoded initialisation in core are fine, i'll remove your code :)

@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/log-mnor-syntax-update branch from 9148d4c to b502b8eCompareMarch 5, 2024 12:49

@emoral435emoral435 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ol' cleaning commit, love to see this 🥳

@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/log-mnor-syntax-update branch 3 times, most recently from 4ece900 to 2d0a80aCompareMarch 11, 2024 13:49
@AltahrimAltahrim mentioned this pull request Mar 12, 2024
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the enh/noid/log-mnor-syntax-update branch from 2d0a80a to 618aaddCompareMarch 12, 2024 11:19
@AltahrimAltahrim mentioned this pull request Mar 14, 2024
@AltahrimAltahrim removed the 3. to review Waiting for reviews label Mar 15, 2024
@AltahrimAltahrim added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Mar 15, 2024
@susnuxsusnux removed the 3. to review Waiting for reviews label Mar 15, 2024
@skjnldsv
skjnldsv merged commit e2f08d9 into masterMar 16, 2024
@skjnldsv
skjnldsv deleted the enh/noid/log-mnor-syntax-update branch March 16, 2024 12:21
@skjnldsvskjnldsv added the technical debt 🧱 🤔🚀 label Mar 16, 2024
This was referenced Mar 17, 2024
@AltahrimAltahrim mentioned this pull request Mar 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishphpPull requests that update Php codetechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ArtificialOwl@MorrisJobke@Altahrim@emoral435@susnux@skjnldsv