Uh oh!
There was an error while loading. Please reload this page.
[stable27] fix: checkbox now allows shift-click and multi-select - #43556
Merged
skjnldsv merged 1 commit intoFeb 22, 2024
Merged
Conversation
skjnldsv
approved these changes
Feb 14, 2024
solracsf
approved these changes
Feb 15, 2024
solracsfforce-pushed
the
fix/42364/allow-multi-select-for-files-when-clicking-checkbox
branch
from
February 15, 2024 12:54
3022b23 to
962905fCompareemoral435
enabled auto-merge
February 15, 2024 13:25
emoral435force-pushed
the
fix/42364/allow-multi-select-for-files-when-clicking-checkbox
branch
2 times, most recently
from
February 19, 2024 18:30
e86de73 to
9771a8eCompareemoral435force-pushed
the
fix/42364/allow-multi-select-for-files-when-clicking-checkbox
branch
from
February 20, 2024 13:03
9771a8e to
ec5e7b1Compare Merged
skjnldsvforce-pushed
the
fix/42364/allow-multi-select-for-files-when-clicking-checkbox
branch
from
February 21, 2024 17:35
ec5e7b1 to
f5516f2Compareskjnldsv
disabled auto-merge
February 22, 2024 07:38
skjnldsv
commented
Feb 22, 2024
Member
|
ContributorAuthor
@skjnldsv Cypress failures seem unrelated: re-ran tests again and they passed 🎉 (failed test is the blocker). Proof: Still needs to be rebased, but should be ready to be merged 🎉 Question though, I tried running |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
emoral435force-pushed
the
fix/42364/allow-multi-select-for-files-when-clicking-checkbox
branch
from
February 22, 2024 15:25
f5516f2 to
abcbea3Comparesolracsf
commented
Feb 22, 2024
Member
Cypress tests seems to be flaky since 2 days in various PRs 😩 |
skjnldsv
commented
Feb 22, 2024
Member
Yeah, we notived some missing cypress fixes for 27. |
skjnldsv
deleted the
fix/42364/allow-multi-select-for-files-when-clicking-checkbox
branch
February 22, 2024 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
PROBLEM: Shift clicking the files in the files app of stabl27 does not allow the functionality to select multiple files at once
PS.. sorry for the weird links, but the gifs showing the difference are there^
Checklist