fix(settings): Deprecate old things for real

[nickvergessen]

Psalm output before:

ERROR: InvalidDocblock - lib/public/Settings/IManager.php:40:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
/**
* @since 9.1.0
* @depreacted 29.0.0 Use {@see self::SETTINGS_ADMIN} instead
*/
public const KEY_ADMIN_SETTINGS = 'admin';
ERROR: InvalidDocblock - lib/public/Settings/IManager.php:46:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
/**
* @since 9.1.0
* @depreacted 29.0.0 Use {@see self::SETTINGS_ADMIN} instead
*/
public const KEY_ADMIN_SECTION = 'admin-section';
ERROR: InvalidDocblock - lib/public/Settings/IManager.php:52:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
/**
* @since 13.0.0
* @depreacted 29.0.0 Use {@see self::SETTINGS_PERSONAL} instead
*/
public const KEY_PERSONAL_SETTINGS = 'personal';
ERROR: InvalidDocblock - lib/public/Settings/IManager.php:58:2 - Typo in @deprecated for const in OCP. (see https://psalm.dev/008)
/**
* @since 13.0.0
* @depreacted 29.0.0 Use {@see self::SETTINGS_PERSONAL} instead
*/
public const KEY_PERSONAL_SECTION = 'personal-section';
------------------------------
4 errors found
------------------------------

Follow up

• Also enforce the @since for constants in OCP => Follow up PR as there are 223 failures 😱

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[skjnldsv]

🐘

[blizzz]

not sure why commented out code was committed