Skip to content

enh: breadcrumbs icons are now more visually descriptive - #43604

Merged
skjnldsv merged 3 commits into
masterfrom
enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view
Feb 16, 2024
Merged

enh: breadcrumbs icons are now more visually descriptive#43604
skjnldsv merged 3 commits into
masterfrom
enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view

Conversation

@emoral435

@emoral435emoral435 commented Feb 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Changed the name path to be something more descriptive for the "/" path, such as the view name
  • All base path urls "/". now are accompanied with descriptive text. perhaps aria-description is no longer needed?

🏡 After

firefox_FroddX5muA

Checklist

@emoral435emoral435 added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Feb 15, 2024
@emoral435emoral435 added this to the Nextcloud 29 milestone Feb 15, 2024
@emoral435emoral435 self-assigned this Feb 15, 2024
@emoral435emoral435 mentioned this pull request Feb 15, 2024
Merged
2 tasks
ShGKme
ShGKme reviewed Feb 15, 2024
View reviewed changes
Comment threadapps/files/src/components/BreadCrumbs.vue Outdated
@emoral435emoral435 mentioned this pull request Feb 15, 2024
Merged
@emoral435
emoral435force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch 2 times, most recently from d4baf28 to 3bd5995CompareFebruary 15, 2024 15:37
skjnldsv
skjnldsv requested changes Feb 15, 2024
View reviewed changes
Comment threadapps/files/src/components/BreadCrumbs.vue Outdated
@emoral435
emoral435force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 3bd5995 to 775c89fCompareFebruary 16, 2024 01:49
@emoral435
emoral435force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 775c89f to 98b41e8CompareFebruary 16, 2024 01:50
skjnldsv

This comment was marked as resolved.

Sign in to view

@emoral435

emoral435 commented Feb 16, 2024

Copy link
Copy Markdown
ContributorAuthor

firefox_GwmTNd6Mwx

I think this looks much cleaner now, good suggestion!

@emoral435
enh: breadcrumbs icons are now more visually descriptive
bbf279f
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435
emoral435force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 98b41e8 to 95bc90eCompareFebruary 16, 2024 14:33
@szaimen

szaimen commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

I think this looks much cleaner now, good suggestion!

Agreed 🤩

skjnldsv
skjnldsv reviewed Feb 16, 2024
View reviewed changes
Comment threadapps/files/src/components/BreadCrumbs.vue Outdated
@skjnldsv

This comment was marked as resolved.

Sign in to view
@nextcloudnextcloud deleted a comment from emoral435Feb 16, 2024
@emoral435
enh: breadcrumb icon matches nav view icon
19619f5
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435
emoral435force-pushed the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch from 95bc90e to 19619f5CompareFebruary 16, 2024 15:11
szaimen
szaimen approved these changes Feb 16, 2024
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from design perspective :)

@skjnldsv

skjnldsv commented Feb 16, 2024

Copy link
Copy Markdown
Member

/compile

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 16, 2024
@nextcloud-command
chore(assets): Recompile assets
e7bd9f0
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit 448a40b into masterFeb 16, 2024
@skjnldsv
skjnldsv deleted the enh/breadcrumbs/43569/apply-breadcrumbs-logic-from-personal-files-to-all-files-view branch February 16, 2024 16:08
@skjnldsv

skjnldsv commented Feb 16, 2024

Copy link
Copy Markdown
Member

/backport to stable28

@backportbot

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv

skjnldsv commented Feb 16, 2024

Copy link
Copy Markdown
Member

/backport to stable28

@backportbotbackportbotBot mentioned this pull request Feb 16, 2024
Merged
2 tasks
@emoral435emoral435 mentioned this pull request Feb 16, 2024
Closed
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@szaimenszaimenszaimen approved these changes
@PytalPytalAwaiting requested review from Pytal
@ShGKmeShGKmeAwaiting requested review from ShGKme

Assignees

@emoral435emoral435

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.enhancement

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Apply Breadcrumb Logic from "Personal files" to all Files views

5 participants

@emoral435@szaimen@skjnldsv@ShGKme@nextcloud-command