Skip to content

Fixes for getting the filename in the FileInfo class - #43652

Merged
skjnldsv merged 12 commits into
nextcloud:masterfrom
hopleus:bugfix/fixed-get-filename-in-fileinfo
Mar 14, 2024
Merged

Fixes for getting the filename in the FileInfo class#43652
skjnldsv merged 12 commits into
nextcloud:masterfrom
hopleus:bugfix/fixed-get-filename-in-fileinfo

Conversation

@hopleus

@hopleushopleus commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

Summary

Fixes for getting the filename in the case when the file name key is received, but it is empty.

P.S. Faced with such a problem with ObjectStore enabled in S3 mode

Checklist

@hopleus

hopleus commented Feb 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@hopleus

hopleus commented Feb 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@hopleus

hopleus commented Feb 19, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@nextcloudnextcloud deleted a comment from hopleusFeb 19, 2024
@solracsfsolracsf added the 3. to review Waiting for reviews label Feb 19, 2024
@solracsfsolracsf added this to the Nextcloud 29 milestone Feb 19, 2024
@solracsf
solracsf requested review from a team, icewind1991, nfebe and sorbaugh and removed request for a teamFebruary 19, 2024 12:58
@hopleus

Copy link
Copy Markdown
ContributorAuthor

@solracsf Hi. Could you run the tests again?

P.S. Last time cypress crashed with 503 errors and I didn't understand why

@AltahrimAltahrim mentioned this pull request Mar 12, 2024
Comment threadlib/private/Files/FileInfo.php Outdated
Signed-off-by: hopleus <hopleus@gmail.com>
@hopleus
hopleus requested a review from AltahrimMarch 12, 2024 14:26
@AltahrimAltahrim mentioned this pull request Mar 14, 2024
@skjnldsv
skjnldsv merged commit f316edb into nextcloud:masterMar 14, 2024
@welcome

welcomeBot commented Mar 14, 2024

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hopleus@icewind1991@Altahrim@solracsf@skjnldsv