Skip to content

[stable28] Fix undefined share object during expirationDate update - #43685

Merged
skjnldsv merged 2 commits into
stable28from
backport/43661/stable28
Feb 22, 2024
Merged

[stable28] Fix undefined share object during expirationDate update#43685
skjnldsv merged 2 commits into
stable28from
backport/43661/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Feb 20, 2024•
edited by nfebe
Loading

Copy link
Copy Markdown

Backport of #43661

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added this to the Nextcloud 28.0.3 milestone Feb 20, 2024
@nfebe
nfebeforce-pushed the backport/43661/stable28 branch from 9164d62 to 853699cCompareFebruary 20, 2024 12:01
@nfebe
nfebe marked this pull request as ready for review February 20, 2024 12:01
@nfebe

nfebe commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

/compile

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews backport-request labels Feb 20, 2024
@skjnldsvskjnldsv mentioned this pull request Feb 21, 2024
Merged
@nfebe
Fix undefined share object during expirationDate update
7200241
In 04e8733 a regression was introduced.
`this` means nothing inside arrow functions, hence this.share was referring to
an undefined object and so all attempted updates for expiration dates would fail.
Resolves : #43256
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
nfebeforce-pushed the backport/43661/stable28 branch from a50c757 to 7200241CompareFebruary 21, 2024 10:53
@nfebe

nfebe commented Feb 21, 2024

Copy link
Copy Markdown
Contributor

/compile

@nextcloud-command
chore(assets): Recompile assets
823143f
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit ff54149 into stable28Feb 22, 2024
@skjnldsv
skjnldsv deleted the backport/43661/stable28 branch February 22, 2024 09:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@nfebenfebenfebe approved these changes
+1 more reviewer
@emoral435emoral435emoral435 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nfebenfebe

Labels

4. to releaseReady to be released and/or waiting for tests to finish28-feedbackfeature: sharing

Projects

None yet

Milestone

Nextcloud 28.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@nfebe@Altahrim@emoral435@skjnldsv@nextcloud-command