Skip to content

[stable27] Fix undefined share object during expirationDate update - #43686

Merged
skjnldsv merged 2 commits into
stable27from
backport/43661/stable27
Feb 22, 2024
Merged

[stable27] Fix undefined share object during expirationDate update#43686
skjnldsv merged 2 commits into
stable27from
backport/43661/stable27

Conversation

@backportbot

@backportbotbackportbotBot commented Feb 20, 2024•
edited by nfebe
Loading

Copy link
Copy Markdown

Backport of #43661

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added this to the Nextcloud 27.1.7 milestone Feb 20, 2024
@nfebe
nfebeforce-pushed the backport/43661/stable27 branch from 2a5a272 to 2df4311CompareFebruary 20, 2024 12:06
@nfebe
nfebe marked this pull request as ready for review February 20, 2024 12:09
@nfebe

nfebe commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

/compile

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 20, 2024
@solracsfsolracsf mentioned this pull request Feb 20, 2024
Closed
9 tasks
@skjnldsvskjnldsv mentioned this pull request Feb 21, 2024
Merged
nfebeand others added 2 commits February 21, 2024 09:54
@nfebe@solracsf
Fix undefined share object during expirationDate update
15e2b5c
In 04e8733 a regression was introduced.
`this` means nothing inside arrow functions, hence this.share was referring to
an undefined object and so all attempted updates for expiration dates would fail.
Resolves : #43256
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nextcloud-command@solracsf
chore(assets): Recompile assets
8d386ed
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@solracsf
solracsfforce-pushed the backport/43661/stable27 branch from 4004615 to 8d386edCompareFebruary 21, 2024 08:54
@skjnldsv
skjnldsv merged commit 9d7abdd into stable27Feb 22, 2024
@skjnldsv
skjnldsv deleted the backport/43661/stable27 branch February 22, 2024 09:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@nfebenfebenfebe approved these changes
+1 more reviewer
@emoral435emoral435emoral435 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@nfebenfebe

Labels

4. to releaseReady to be released and/or waiting for tests to finish28-feedbackfeature: sharing

Projects

None yet

Milestone

Nextcloud 27.1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@nfebe@Altahrim@emoral435@skjnldsv@nextcloud-command