Uh oh!
There was an error while loading. Please reload this page.
fix(styles): Add default styles for disabled elements - #43697
Merged
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
ChristophWurst, Pytal, jancborchardt and skjnldsvFebruary 20, 2024 16:02
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/default-inputs-style
branch
from
February 20, 2024 16:07
d581d1b to
6a9daa3Compareszaimen
approved these changes
Feb 20, 2024
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Screenshot looks good to me but did not review the code and did not test
skjnldsv
approved these changes
Feb 20, 2024
susnux
commented
Feb 20, 2024
ContributorAuthor
/backport to stable28 |
2 tasks
ChristophWurst
commented
Feb 21, 2024
Member
👍 thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add default styles to disabled input elements.
Also replace deprecated variables
color-text-lightwithcolor-main-textandcolor-text-lighterwithcolor-text-maxcontrast. The variables are aliases currently but are scheduled for removal.Screenshots
Checklist