Skip to content

[stable28] fix(dav): Rate limit calendar/subscription creation - #43751

Merged
skjnldsv merged 1 commit into
stable28from
backport/43732/stable28
Feb 22, 2024
Merged

[stable28] fix(dav): Rate limit calendar/subscription creation#43751
skjnldsv merged 1 commit into
stable28from
backport/43732/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Feb 22, 2024•
edited by ChristophWurst
Loading

Copy link
Copy Markdown

Backport of #43732

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added bug 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels Feb 22, 2024
@backportbotbackportbotBot added this to the Nextcloud 28.0.3 milestone Feb 22, 2024
@ChristophWurst
ChristophWurst marked this pull request as ready for review February 22, 2024 08:55
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 22, 2024
View reviewed changes
Comment threadapps/dav/lib/CalDAV/Security/RateLimitingPlugin.php Fixed
Comment threadapps/dav/lib/CalDAV/Security/RateLimitingPlugin.php Fixed
Comment threadapps/dav/lib/CalDAV/Security/RateLimitingPlugin.php Fixed
@ChristophWurst
ChristophWurst marked this pull request as draft February 22, 2024 09:11
@ChristophWurst

ChristophWurst commented Feb 22, 2024

Copy link
Copy Markdown
Member

\OCP\IAppConfig::getValueInt is new in 29. Adjusting the backports 🥲

@skjnldsvskjnldsv mentioned this pull request Feb 22, 2024
Merged
@ChristophWurst

ChristophWurst commented Feb 22, 2024

Copy link
Copy Markdown
Member

Tested and works (again)

@ChristophWurst
ChristophWurst marked this pull request as ready for review February 22, 2024 09:44
@nickvergessen

nickvergessen commented Feb 22, 2024

Copy link
Copy Markdown
Member

Cypress are you okay?

@susnuxsusnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 22, 2024
@ChristophWurst
fix(dav): Rate limit calendar/subscription creation
c7ddc5f
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsv
skjnldsv merged commit e09053f into stable28Feb 22, 2024
@skjnldsv
skjnldsv deleted the backport/43732/stable28 branch February 22, 2024 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: caldavRelated to CalDAV internalsfeature: davhigh

Projects

None yet

Milestone

Nextcloud 28.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@ChristophWurst@nickvergessen@miaulalala@github-advanced-security@susnux@skjnldsv