Uh oh!
There was an error while loading. Please reload this page.
Beautify test email - #4379
Merged
Merged
Conversation
mention-bot
commented
Apr 18, 2017
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen and @MorrisJobke to be potential reviewers. |
| $message->setTo([$email => $this->userSession->getUser()->getDisplayName()]); | ||
| $message->setFrom([$this->defaultMailAddress]); | ||
| $message->setSubject($this->l10n->t('test email settings')); | ||
| $message->setPlainBody('If you received this email, the settings seem to be correct.'); |
MemberAuthor
There was a problem hiding this comment.
Was not even translated before 🙈
| } | ||
| return array('data' => | ||
| array('message' => |
There was a problem hiding this comment.
I fixed this in the other PR today #4372
| $message = $this->mailer->createMessage(); | ||
| $message->setTo([$email => $this->userSession->getUser()->getDisplayName()]); | ||
| $message->setFrom([$this->defaultMailAddress]); |
There was a problem hiding this comment.
from doesn't seem to be set now – was that intended? 😉
ChristophWurst
approved these changes
Apr 18, 2017
MorrisJobke
commented
Apr 18, 2017
Member
Let me rebase and fix the conflicts. |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
MorrisJobkeforce-pushed
the
nicely-designed-confirmation-mail
branch
from
April 18, 2017 21:18
77eeed6 to
0a54d5aCompareCodecov Report
@@ Coverage Diff @@## master #4379 +/- ##
=========================================
Coverage ? 54.08% Complexity ? 21589 =========================================
Files ? 1327 Lines ? 82311 Branches ? 1305 =========================================
Hits ? 44519 Misses ? 37792 Partials ? 0
|
MorrisJobke added a commit
that referenced
this pull request
Feb 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vs.