Skip to content

[stable25] Check share status when touching versions - #43859

Merged
sorbaugh merged 1 commit into
stable25from
backport/43727/stable25
Feb 27, 2024
Merged

[stable25] Check share status when touching versions#43859
sorbaugh merged 1 commit into
stable25from
backport/43727/stable25

Conversation

@backportbot

@backportbotbackportbotBot commented Feb 27, 2024•
edited by artonge
Loading

Copy link
Copy Markdown

Backport of #43727

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added 3. to review Waiting for reviews feature: versions javascript php Pull requests that update Php code labels Feb 27, 2024
@artonge
artongeforce-pushed the backport/43727/stable25 branch 3 times, most recently from bc3a1f1 to 998d3bcCompareFebruary 27, 2024 10:06
@artonge
artonge marked this pull request as ready for review February 27, 2024 10:06
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 27, 2024
View reviewed changes
Comment threadapps/dav/lib/DAV/ViewOnlyPlugin.php Fixed
Comment threadapps/dav/lib/DAV/ViewOnlyPlugin.php Fixed
Comment threadapps/dav/lib/DAV/ViewOnlyPlugin.php Fixed
Comment threadapps/dav/lib/DAV/ViewOnlyPlugin.php Fixed
Comment threadapps/dav/lib/DAV/ViewOnlyPlugin.php Fixed
@artonge
artongeforce-pushed the backport/43727/stable25 branch from 998d3bc to 26eae60CompareFebruary 27, 2024 10:34
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 27, 2024
View reviewed changes
Comment threadapps/dav/lib/DAV/ViewOnlyPlugin.php
} else if ($davNode instanceof VersionFile) {
} elseif ($davNode instanceof VersionFile) {
$node = $davNode->getVersion()->getSourceFile();
$currentUserId = $this->userFolder->getOwner()->getUID();

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method getOwner on possibly null value
@artonge

artonge commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

/backport to stable24

@artonge
Check share attributes when downloading versions
4c289aa
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
artongeforce-pushed the backport/43727/stable25 branch from 26eae60 to 4c289aaCompareFebruary 27, 2024 11:08
@artonge

artonge commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

CI failure unrelated

@artongeartonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2024
@sorbaugh
sorbaugh merged commit 00bee4f into stable25Feb 27, 2024
@sorbaugh
sorbaugh deleted the backport/43727/stable25 branch February 27, 2024 13:18
@backportbotbackportbotBot mentioned this pull request Feb 27, 2024
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@nfebenfebenfebe approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@susnuxsusnuxAwaiting requested review from susnux

Assignees

@artongeartonge

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: versionsjavascriptphpPull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@artonge@nfebe@github-advanced-security@sorbaugh