Uh oh!
There was an error while loading. Please reload this page.
[stable23] Check share status when restoring versions - #43874
Merged
Conversation
artongeforce-pushed
the
backport/43727/stable23
branch
from
February 27, 2024 15:48
20cec42 to
b6ef916Compareartonge
marked this pull request as ready for review
February 27, 2024 15:50
artonge
approved these changes
Feb 27, 2024
artongeforce-pushed
the
backport/43727/stable23
branch
from
February 27, 2024 17:00
b6ef916 to
bbb88e8Compare| private function currentUserHasPermissions(IVersion $version, int $permissions): bool { | ||
| $sourceFile = $version->getSourceFile(); | ||
| $currentUserId = $this->userSession->getUser()->getUID(); |
Check notice
Code scanning / Psalm
PossiblyNullReference
| $sourceFile = $version->getSourceFile(); | ||
| $currentUserId = $this->userSession->getUser()->getUID(); | ||
| if ($currentUserId === null) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
backport/43727/stable23
branch
from
February 28, 2024 09:18
bbb88e8 to
db2085cCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #43727
Warning, This backport's changes differ from the original and might be incomplete⚠️ Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.