Uh oh!
There was an error while loading. Please reload this page.
Improve files version listing - #43898
Conversation
d7288c2 to
8705ddcCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| $versionEntity->getTimestamp(), | ||
| $versionEntity->getTimestamp(), | ||
| $version = new Version( | ||
| $versions['db']->getTimestamp(), |
Check notice
Code scanning / Psalm
PossiblyNullReference
| $versionEntity->getSize(), | ||
| $this->mimeTypeLoader->getMimetypeById($versionEntity->getMimetype()), | ||
| $versions['db']->getSize(), | ||
| $this->mimeTypeLoader->getMimetypeById($versions['db']->getMimetype()), |
Check notice
Code scanning / Psalm
PossiblyNullArgument
cfebdee to
e2b7774CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e2b7774 to
866b56cCompareSigned-off-by: Louis Chemineau <louis@chmn.me>
866b56c to
8705727Compareartonge
commented
Mar 4, 2024
/backport to stable28 |
artonge
commented
Mar 4, 2024
/backport to stable27 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/43898/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 87057278
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43898/stable28Error: Failed to push branch backport/43898/stable28: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
artonge
commented
Mar 4, 2024
/backport to stable28 |
mahibi
commented
Mar 5, 2024
/backport to stable26 |
1 similar comment
artonge
commented
Mar 5, 2024
/backport to stable26 |
In too many cases, the list of version in the DB failed to match the list of version in the FS.
This PR changes the listing approach
from: "return DB listing unless it is empty, if it is empty, then populate DB based on FS and return DB listing"
to: "return a merge of DB and FS listing, while doing the merge, prune DB entries if no counterpart FS entries exist, and create DB entries if it is missing".
This trades a bit of performance, against DB integrity, code simplification, and reliability.
Possible followups: