Skip to content

fix: Avoid clear cache with prefix - #43992

Merged
skjnldsv merged 1 commit into
masterfrom
fix/avoid-cache-clear
Mar 8, 2024
Merged

fix: Avoid clear cache with prefix#43992
skjnldsv merged 1 commit into
masterfrom
fix/avoid-cache-clear

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Mar 5, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Calling clear on Redis is a heavy operation and can result in slow queries there. For the reference cache we can avoid in cases we know that we have never set entries with a prefix.

One common case is file references where we always called clear on file deletion, share adding/removal even though no references to those files were used.

@juliusknorr
juliusknorr requested review from a team, ArtificialOwl, icewind1991, julien-nc, nfebe and nickvergessen and removed request for a teamMarch 5, 2024 10:04
@juliusknorrjuliusknorr added this to the Nextcloud 29 milestone Mar 5, 2024
@juliusknorr

juliusknorr commented Mar 5, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@juliusknorr

juliusknorr commented Mar 5, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@juliusknorr

juliusknorr commented Mar 5, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@juliusknorr

juliusknorr commented Mar 5, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable25

github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 5, 2024
View reviewed changes
Comment threadlib/private/Collaboration/Reference/ReferenceManager.php Fixed
Comment threadlib/private/Collaboration/Reference/ReferenceManager.php Fixed
@juliusknorr
juliusknorrforce-pushed the fix/avoid-cache-clear branch 2 times, most recently from ae4999b to 4b5250eCompareMarch 5, 2024 19:50
@skjnldsv
skjnldsvforce-pushed the fix/avoid-cache-clear branch from 4b5250e to 3acf087CompareMarch 7, 2024 21:58
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 7, 2024
@skjnldsv
skjnldsv enabled auto-merge March 7, 2024 21:58
@nickvergessen

nickvergessen commented Mar 8, 2024

Copy link
Copy Markdown
Member

There were 17 failures:

  1. OCA\UpdateNotification\Tests\Controller\AdminControllerTest::testCreateCredentials

Because @susnux PR was merged without passing CI, so either needs a rebase after #44074 is in or another blind red CI merge

@juliusknorr@nickvergessen
fix: Avoid clear cache with prefix
972a611
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv
skjnldsv merged commit b6691b3 into masterMar 8, 2024
@skjnldsv
skjnldsv deleted the fix/avoid-cache-clear branch March 8, 2024 08:37
This was referenced Mar 8, 2024
Merged
Merged
Merged
Merged
@AltahrimAltahrim mentioned this pull request Mar 12, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@icewind1991icewind1991icewind1991 approved these changes
@julien-ncjulien-ncAwaiting requested review from julien-nc
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugperformance 🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@nickvergessen@icewind1991@github-advanced-security@skjnldsv