Uh oh!
There was an error while loading. Please reload this page.
fix(user_ldap): Catch DB Exceptions when updating group memberships - #43999
Merged
come-nc merged 1 commit intoMar 6, 2024
Merged
Conversation
come-nc
requested review from
a team, ArtificialOwl and nfebe
and removed request for
a teamMarch 5, 2024 14:01
icewind1991
commented
Mar 5, 2024
Member
it probably makes sense to catch the unique errors in the |
come-nc
commented
Mar 5, 2024
ContributorAuthor
But no other mapper is doing so, the insert/delete methods are standard from parent class? |
icewind1991
commented
Mar 5, 2024
Member
Fair enough |
icewind1991
approved these changes
Mar 5, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-ncforce-pushed
the
fix/user_ldap-catch-db-errors-when-updating-group-memberships
branch
from
March 6, 2024 09:19
1be40c5 to
d163347CompareArtificialOwl
approved these changes
Mar 6, 2024
come-nc
deleted the
fix/user_ldap-catch-db-errors-when-updating-group-memberships
branch
March 6, 2024 10:44
Merged
kesselb
commented
Aug 19, 2024
Contributor
What about a backport for 28? I just found this case 36 times (from 2024-08-05 to 2024-08-19) in a logfile. |
come-nc
commented
Aug 20, 2024
ContributorAuthor
/backport to stable28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When inserting/deleting group membership, it may simply fail because another job or request is doing the same thing concurrently. In this case we must not crash but simply ignore the error. When it fails for unexpected reason, we must log it but not crash.
Checklist