Skip to content

feat: add pronouns to account profile - #44013

Merged
skjnldsv merged 2 commits into
masterfrom
fieat/profile-pronounces
Sep 17, 2024
Merged

feat: add pronouns to account profile#44013
skjnldsv merged 2 commits into
masterfrom
fieat/profile-pronounces

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Mar 5, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Fix#40017

DesktopMobile
2024-09-17_23-322024-09-17_23-31

image
image

  • Add free text input to enter pronouns
  • Always show the pronouns next to the displayName

github-advanced-security[bot]
github-advanced-securityAI found potential problems Mar 5, 2024
View reviewed changes
Comment threadapps/provisioning_api/lib/Controller/AUserData.php Fixed
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Fixed
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Fixed
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Fixed
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Fixed
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Fixed
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Fixed
Comment threadapps/settings/lib/Settings/Personal/PersonalInfo.php Fixed
@skjnldsv
skjnldsvforce-pushed the fieat/profile-pronounces branch from bd95aa8 to 3d77190CompareMarch 6, 2024 09:12
susnux
susnux reviewed Mar 6, 2024
View reviewed changes
Comment threadapps/settings/src/components/PersonalInfo/PronounsSection.vue Outdated
@skjnldsvskjnldsv added 2. developing Work in progress feature: settings feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Mar 6, 2024
Pytal
Pytal reviewed Mar 7, 2024
View reviewed changes
Comment threadapps/settings/src/components/PersonalInfo/PronounsSection.vue Outdated
Comment threadlib/private/Accounts/AccountManager.php
Pytal

This comment was marked as resolved.

Sign in to view

@skjnldsvskjnldsv added this to the Nextcloud 30 milestone Mar 7, 2024
@botsarenthuman

This comment was marked as off-topic.

Sign in to view
jancborchardt
jancborchardt approved these changes Aug 8, 2024
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and looks good design-wise! They will also show in the visibility settings, right?

Can you show a screenshot how it will look like on the profile? I assume subline like the other things, possibly divided by the middle dot we often use? ·

@skjnldsv

This comment has been minimized.

Sign in to view
@botsarenthuman

This comment was marked as off-topic.

Sign in to view
@nextcloudnextcloud locked as too heated and limited conversation to collaborators Aug 8, 2024
@skjnldsv

skjnldsv commented Aug 8, 2024

Copy link
Copy Markdown
MemberAuthor

It's just not the place to have a discussion on if a feature is controversial or not.
I'm proactively locking to not be distracted by future comments 🤟

@jancborchardt

jancborchardt commented Aug 8, 2024

Copy link
Copy Markdown
Member

Please make this optional, or opt-in

It's optional to put in pronouns, soo …

@skjnldsv
skjnldsvforce-pushed the fieat/profile-pronounces branch from d934fba to 64549d0CompareSeptember 17, 2024 20:05
@skjnldsv
feat: add profile pronouns
26abc86
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fieat/profile-pronounces branch 3 times, most recently from 8a4e7c3 to 2e04ce6CompareSeptember 17, 2024 22:11
@skjnldsv
fix(core): profile design and pronouns support
b24e02e
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fieat/profile-pronounces branch from 2e04ce6 to b24e02eCompareSeptember 17, 2024 22:16
@skjnldsv

skjnldsv commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

Let's go!! 🚀
I'll see how we can improve the user hover menu as a follow-up!

@skjnldsv
skjnldsv requested review from Pytal and susnux and removed request for Pytal and susnuxSeptember 17, 2024 23:00
@skjnldsv
skjnldsv requested review from a team, Pytal, artonge and susnux and removed request for a teamSeptember 17, 2024 23:00
@skjnldsv
skjnldsv marked this pull request as ready for review September 17, 2024 23:00
@skjnldsv
skjnldsv requested review from a team and removed request for provokateurinSeptember 17, 2024 23:01
@skjnldsvskjnldsv added 3. to review Waiting for reviews inclusivity 🌈 and removed 2. developing Work in progress labels Sep 17, 2024
Pytal
Pytal approved these changes Sep 17, 2024
View reviewed changes

@PytalPytal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

No idea about LDAP part 🙈

Comment threadcore/src/views/Profile.vue
Comment on lines +441 to +442
// Overlap avatar to top header
margin-top: -110px !important;

@PytalPytalSep 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Overlap avatar to top header
margin-top: -110px !important;
// Overlap avatar to top header
margin-top: -110px !important;

@skjnldsv
skjnldsv merged commit 6bcab26 into masterSep 17, 2024
@skjnldsv
skjnldsv deleted the fieat/profile-pronounces branch September 17, 2024 23:25
@skjnldsv

skjnldsv commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

Code looks good!

No idea about LDAP part 🙈

I'll double check with Arthur tomorrow :)

@come-nc

come-nc commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

@skjnldsv This broke the tests but the CI was wrongly green.
Please do a follow-up PR to fix the related tests.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jancborchardtjancborchardtjancborchardt approved these changes
@PytalPytalPytal approved these changes
@artongeartongeAwaiting requested review from artonge
@susnuxsusnuxAwaiting requested review from susnuxsusnux is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsfeature: profilePRs or issues related to the Profile feature (e.g. Profile page, API, etc.)feature: settingsinclusivity 🌈🍀 2025-Spring

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

Allow setting third person pronouns in user's profile

8 participants

@skjnldsv@botsarenthuman@jancborchardt@come-nc@susnux@Pytal@github-advanced-security@AndyScherzinger