Uh oh!
There was an error while loading. Please reload this page.
Migrate header check to setupcheck API - #44067
Merged
Merged
Conversation
33 tasks
come-ncforce-pushed
the
fix/migrate-header-check-to-setupcheck
branch
4 times, most recently
from
March 12, 2024 15:39
27eee79 to
225cf90Comparecome-nc
commented
Mar 12, 2024
ContributorAuthor
/compile / |
come-nc
requested review from
a team, Altahrim, ArtificialOwl, icewind1991 and susnux
and removed request for
a teamMarch 12, 2024 16:52
susnux
reviewed
Mar 12, 2024
| ]; | ||
| foreach ($providers as $provider) { | ||
| foreach ($this->runHEAD($this->urlGenerator->getWebroot() . $provider) as $response) { |
Contributor
There was a problem hiding this comment.
If that is removed, then drop also runHEAD function?
ContributorAuthor
There was a problem hiding this comment.
Still used in other checks I think but yeah we could move all of them.
come-ncforce-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
March 12, 2024 16:59
1f7d36d to
dd211d0Comparecome-nc
commented
Mar 12, 2024
ContributorAuthor
/compile / |
Merged
Altahrim
approved these changes
Mar 13, 2024
Altahrim
left a comment
Collaborator
There was a problem hiding this comment.
If domain contains only one dot (xxxxx.yyy), we could also advise to use HSTS includeSubDomains and preload (https://hstspreload.org/)
Uh oh!
There was an error while loading. Please reload this page.
susnux
approved these changes
Mar 13, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ementation Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
susnuxforce-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
March 13, 2024 11:49
7b00b81 to
99e967aComparesusnux
commented
Mar 13, 2024
Contributor
/compile amend |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
March 13, 2024 12:07
99e967a to
58ae7e4Compare Merged
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
commented
Mar 14, 2024
ContributorAuthor
I do not have any knowledge about this, I’d say that would be a followup, let’s migrate the feature first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #41364
Summary
Security related header check migrated to new API and done from backend now.
TODO:
Checklist