Uh oh!
There was an error while loading. Please reload this page.
fix: No password set for new mail shares - #44184
Merged
Merged
Conversation
Before the password is set on a new share, the computed property `hasUnsavedPassword` is used to check that `this.share.newPassword` is not undefined. Direct assignment without using Vue's `this.$set` makes it impossible for vue to detect that changes have happened on the share object. Hence the inreactivity. This worked initially most likely because `this.share.newPassword = await GeneratePassword()` was executed before the computed properties where evaluated. Resolves : #43919 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebeforce-pushed
the
43919-fix-share-by-mail-password-enforce
branch
from
March 13, 2024 23:59
84c078d to
f9bef8fComparenfebe
commented
Mar 13, 2024
ContributorAuthor
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
artonge
approved these changes
Mar 14, 2024
susnux
approved these changes
Mar 14, 2024
susnux
commented
Mar 14, 2024
Contributor
/backport to stable28 |
susnux
commented
Mar 14, 2024
Contributor
/backport to stable27 |
2 tasks
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/44184/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick f9bef8f3 e3621b6d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44184/stable28Error: Failed to push branch backport/44184/stable28: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
susnux
commented
Mar 14, 2024
Contributor
/backport to stable28 |
2 tasks
Merged
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the password is set on a new share, the computed property
hasUnsavedPasswordis used to check thatthis.share.newPasswordis not undefined. Direct assignment without using Vue'sthis.$setmakes it impossible for vue to detect that changes have happened on the share object. Hence the inreactivity.This worked initially most likely because
this.share.newPassword = await GeneratePassword()was executed before the computed properties where evaluated.Resolves : #43919