Uh oh!
There was an error while loading. Please reload this page.
feat: Limit email input to 255 chars - #44218
Merged
Merged
Conversation
nfebeforce-pushed
the
613-limit-auth-input-emails-255
branch
2 times, most recently
from
March 15, 2024 11:17
00a96a9 to
21c61c8Comparenfebeforce-pushed
the
613-limit-auth-input-emails-255
branch
2 times, most recently
from
March 16, 2024 00:15
4f9dee4 to
b6a0c6aCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nfebe
marked this pull request as ready for review
March 16, 2024 00:22
nfebeforce-pushed
the
613-limit-auth-input-emails-255
branch
from
March 16, 2024 00:28
b6a0c6a to
c9ca17dCompareskjnldsv
commented
Mar 16, 2024
Member
Labels pleaaase :) |
susnux
reviewed
Mar 17, 2024
Uh oh!
There was an error while loading. Please reload this page.
Merged
nfebeforce-pushed
the
613-limit-auth-input-emails-255
branch
from
March 18, 2024 19:30
c9ca17d to
301b3d4Compare| return $this->createLoginFailedResponse( | ||
| $user, | ||
| $user, | ||
| $redirect_url, |
Check notice
Code scanning / Psalm
PossiblyNullArgument
Collaborator
There was a problem hiding this comment.
Maybe the following or change default on line 317:
Suggested change
| $redirect_url, | |
| (string) $redirect_url, |
Uh oh!
There was an error while loading. Please reload this page.
Merged
nfebeforce-pushed
the
613-limit-auth-input-emails-255
branch
from
March 20, 2024 15:43
301b3d4 to
ada4138Comparesusnux
reviewed
Mar 20, 2024
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
613-limit-auth-input-emails-255
branch
from
March 20, 2024 16:52
ada4138 to
4a80230Comparesusnux
approved these changes
Mar 20, 2024
Altahrim
approved these changes
Mar 21, 2024
Excessively long emails reported make server unresponsive. We could at some point, consider adding a configuration for sysadmins to bypass this setting on their instance if they want. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebeforce-pushed
the
613-limit-auth-input-emails-255
branch
from
March 21, 2024 09:36
4a80230 to
2792d8bComparenfebe
commented
Mar 21, 2024
ContributorAuthor
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
commented
May 13, 2024
ContributorAuthor
/backport to stable29 |
nfebe
commented
May 13, 2024
ContributorAuthor
/backport to stable28 |
nfebe
commented
May 13, 2024
ContributorAuthor
/backport to stable27 |
2 tasks
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots