Uh oh!
There was an error while loading. Please reload this page.
fix(Logger): Warn on invalid loglevel configuration option - #44262
Merged
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
a team, ArtificialOwl, nfebe, nickvergessen and sorbaugh
and removed request for
a teamMarch 17, 2024 20:17
Altahrim
approved these changes
Mar 18, 2024
nickvergessen
approved these changes
Mar 18, 2024
come-nc
approved these changes
Mar 18, 2024
Merged
skjnldsv
commented
Mar 19, 2024
Member
Thank you for the additional fix :) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the configuration is not a valid integer do not silently fallback to warn, instead try to cast it (might be more what the admin wanted to configure, e.g. allows
'0'when0was meant).And if the value is invalid do handle it not silently but at least put a warning in the log (even we do not have access to the logger we can put it in the error log.
Checklist