Uh oh!
There was an error while loading. Please reload this page.
fix(files_external): Remove invalid jQuery Tooltip usage - #44264
Conversation
This caused the UI to throw an error causing it to be unusable. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
come-nc
commented
Mar 18, 2024
@susnux |
come-nc
left a comment
There was a problem hiding this comment.
UI is working again with this PR.
Only problem I’ve spotted: clicking the 3-dot button opens a menu, but clicking it again does not close it, the user have to find a spot in the UI that does nothing and click it, it’s the only way to close this menu.
come-nc
commented
Mar 18, 2024
Actually not sure if 28 is impacted or not, @susnux ? |
szaimen
left a comment
There was a problem hiding this comment.
tested and seems to work :)
susnux
commented
Mar 18, 2024
No stable 28 was not affected, we only did this for 29 iirc. |
susnux
commented
Mar 18, 2024
Unrelated, those should not cause problems. The 3-dot menu is another issue. I hope to find time to migrate the settings to vue soon 😉 |
Summary
The tooltip methods were remove long ago but we removed the "polyfill" (try-catch) so this caused the UI to throw an error causing it to be unusable.
Checklist