Skip to content

Show upload menu in folders' emptycontent - #44272

Merged
skjnldsv merged 2 commits into
masterfrom
feature/40205/show-add-menu-in-emptycontent
May 29, 2024
Merged

Show upload menu in folders' emptycontent#44272
skjnldsv merged 2 commits into
masterfrom
feature/40205/show-add-menu-in-emptycontent

Conversation

@marcoambrosini

@marcoambrosinimarcoambrosini commented Mar 18, 2024

Copy link
Copy Markdown
Member

@marcoambrosinimarcoambrosini added the 3. to review Waiting for reviews label Mar 18, 2024
@marcoambrosinimarcoambrosini self-assigned this Mar 18, 2024
@marcoambrosini
marcoambrosini requested review from a team and szaimenMarch 18, 2024 11:59
@marcoambrosini
marcoambrosiniforce-pushed the feature/40205/show-add-menu-in-emptycontent branch from 17ac04c to 45f02fbCompareMarch 18, 2024 12:01
szaimen
szaimen approved these changes Mar 18, 2024
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work. Really nice UX improvement! :)

@szaimenszaimen added this to the Nextcloud 29 milestone Mar 18, 2024
susnux
susnux approved these changes Mar 18, 2024
View reviewed changes

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice UX!

@AltahrimAltahrim mentioned this pull request Mar 18, 2024
Merged
@susnux

susnux commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

@marcoambrosini can you please adjust your commit message to comply with conventional commits? :)

skjnldsv
skjnldsv requested changes Mar 19, 2024
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message does not mean the folder truly exists

@marcoambrosini

marcoambrosini commented Mar 19, 2024

Copy link
Copy Markdown
MemberAuthor

So what would be the best way to check that the folder exists @skjnldsv

@skjnldsv

skjnldsv commented Mar 19, 2024

Copy link
Copy Markdown
Member

There are many factors you need to check to show an UploadPicker

  1. Does the directory exists (see currentFolder)
  2. Does the user have create permissions on that folder ?

Additional data:

What you are editing is shared between ALL views, the deleted files, the tags, the shares, favorites.... etc. We need to keep the Go Back feature alongside the upload picker.

This was referenced Mar 20, 2024
Merged
Merged
@jancborchardt

jancborchardt commented Mar 26, 2024

Copy link
Copy Markdown
Member

@marcoambrosini do you still want to have this in beta 6? If so, the last call for that is happening now, otherwise we have to move it to 30.

@skjnldsv

skjnldsv commented Mar 26, 2024

Copy link
Copy Markdown
Member

@jancborchardt we're far into features freeze (3 weeks) and Rc1 is this week

@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
This was referenced Apr 4, 2024
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 29, Nextcloud 30Apr 8, 2024
@susnux
susnuxforce-pushed the feature/40205/show-add-menu-in-emptycontent branch 2 times, most recently from a47732f to 6ba706aCompareMay 16, 2024 21:40
@susnux
susnux requested a review from skjnldsvMay 16, 2024 21:40
@susnux

susnux commented May 16, 2024

Copy link
Copy Markdown
Contributor

@skjnldsv@marcoambrosini I pushed a commit to bring back the back button if upload is not possible.

@susnux
susnuxforce-pushed the feature/40205/show-add-menu-in-emptycontent branch from 6ba706a to bd4a107CompareMay 16, 2024 21:43
@susnux

susnux commented May 17, 2024

Copy link
Copy Markdown
Contributor

/compile

skjnldsv
skjnldsv approved these changes May 17, 2024
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@marcoambrosini

marcoambrosini commented May 29, 2024

Copy link
Copy Markdown
MemberAuthor

I can't figure out what's wrong with the failures

marcoambrosiniand others added 2 commits May 29, 2024 14:44
@marcoambrosini@susnux
feat(files): Show upload menu in folders' emptycontent
1526a6f
Signed-off-by: Marco <marcoambrosini@icloud.com>
@susnux
fix(files): Keep 'back'-button for not found directories or if user c…
1463592
…an not upload
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the feature/40205/show-add-menu-in-emptycontent branch from 65b1156 to 1463592CompareMay 29, 2024 12:47
@skjnldsv
skjnldsv merged commit 9277def into masterMay 29, 2024
@skjnldsv
skjnldsv deleted the feature/40205/show-add-menu-in-emptycontent branch May 29, 2024 15:11
@skjnldsv

skjnldsv commented May 29, 2024

Copy link
Copy Markdown
Member

Thanks @susnux !

@marcoambrosini

marcoambrosini commented May 29, 2024

Copy link
Copy Markdown
MemberAuthor

What was it @susnux ?

@susnux

susnux commented May 29, 2024

Copy link
Copy Markdown
Contributor

What was it @susnux ?

Just flaky and needed to be restarted

@blizzzblizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@PytalPytalPytal approved these changes
@szaimenszaimenszaimen approved these changes

Assignees

@marcoambrosinimarcoambrosini

Labels

3. to reviewWaiting for reviewsenhancement

Projects

🖍 Design team
Archived in project

Milestone

Nextcloud 30

Development

Successfully merging this pull request may close these issues.

Should the empty folder button ask to upload something instead of going back?

7 participants

@marcoambrosini@susnux@skjnldsv@jancborchardt@Pytal@szaimen@blizzz