Skip to content

fix(config): Make sure user keys are strings - #44276

Merged
skjnldsv merged 1 commit into
masterfrom
fix/config/string-user-keys
Mar 20, 2024
Merged

fix(config): Make sure user keys are strings#44276
skjnldsv merged 1 commit into
masterfrom
fix/config/string-user-keys

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Mar 18, 2024•
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

array_keys returns string[]|int[] and out API should only return string[].

TODO

  • ...

Checklist

@ChristophWurst
fix(config): Make sure user keys are strings
b8868e2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurst marked this pull request as ready for review March 19, 2024 17:28
@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 19, 2024
@ChristophWurst
ChristophWurstforce-pushed the fix/config/string-user-keys branch from c370652 to b8868e2CompareMarch 19, 2024 17:28
@ChristophWurst

ChristophWurst commented Mar 19, 2024

Copy link
Copy Markdown
MemberAuthor

/backport! to stable28

@ChristophWurst

ChristophWurst commented Mar 19, 2024

Copy link
Copy Markdown
MemberAuthor

/backport! to stable27

@ChristophWurst

ChristophWurst commented Mar 19, 2024

Copy link
Copy Markdown
MemberAuthor

/backport! to stable26

@backportbotbackportbotBot mentioned this pull request Mar 19, 2024
Merged
@ChristophWurstChristophWurst added this to the Nextcloud 29 milestone Mar 19, 2024
This was referenced Mar 19, 2024
Merged
Merged
@AltahrimAltahrim mentioned this pull request Mar 19, 2024
Merged
skjnldsv
skjnldsv approved these changes Mar 20, 2024
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test

@skjnldsv
skjnldsv merged commit c34e252 into masterMar 20, 2024
@skjnldsv
skjnldsv deleted the fix/config/string-user-keys branch March 20, 2024 07:19
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 20, 2024
@AltahrimAltahrim mentioned this pull request Mar 20, 2024
Merged
@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport! to stable25

@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable24

@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable23

@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@ChristophWurst

ChristophWurst commented Mar 26, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@backportbotbackportbotBot mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 26, 2024
Merged
Merged
Merged
Merged
@DeepDiver1975DeepDiver1975 mentioned this pull request Jun 18, 2024
Merged
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@st3inyst3inyAwaiting requested review from st3iny

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst@nickvergessen@skjnldsv