Skip to content

fix(dav): Fix quota check for chunk upload - #44332

Merged
come-nc merged 2 commits into
masterfrom
fix/fix-chunkupload-quota-check
Apr 2, 2024
Merged

fix(dav): Fix quota check for chunk upload#44332
come-nc merged 2 commits into
masterfrom
fix/fix-chunkupload-quota-check

Conversation

@come-nc

@come-nccome-nc commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

Summary

Do not ignore header OC-Total-Length when Content-Length and X-Expected-Entity-Length are missing.

Checklist

@come-nccome-nc added the 3. to review Waiting for reviews label Mar 19, 2024
@come-nccome-nc added this to the Nextcloud 29 milestone Mar 19, 2024
@come-nc
come-nc requested review from a team and skjnldsvMarch 19, 2024 16:27
@come-nccome-nc self-assigned this Mar 19, 2024
@come-nc
come-nc requested review from ArtificialOwl and nfebe and removed request for a teamMarch 19, 2024 16:27
@AltahrimAltahrim mentioned this pull request Mar 19, 2024
@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable28

@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable27

This was referenced Mar 20, 2024
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@come-nc
come-ncforce-pushed the fix/fix-chunkupload-quota-check branch from 176e853 to d3f2442CompareApril 2, 2024 07:58
@come-nccome-nc modified the milestones: Nextcloud 29, Nextcloud 30Apr 2, 2024
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

Do not ignore OC-Total-Length when Content-Length and
X-Expected-Entity-Length are missing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the fix/fix-chunkupload-quota-check branch from d3f2442 to 01f59beCompareApril 2, 2024 12:16
@come-nc
come-nc merged commit 9aa7225 into masterApr 2, 2024
@come-nc
come-nc deleted the fix/fix-chunkupload-quota-check branch April 2, 2024 15:44
@backportbot

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/44332/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 516fb702 01f59be5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44332/stable27

Error: Failed to push branch backport/44332/stable27: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

Copy link
Copy Markdown

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/44332/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 516fb702 01f59be5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44332/stable28

Error: Failed to push branch backport/44332/stable28: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc@skjnldsv@nfebe