Skip to content

fix(caldav): add EXDATE and EXRULE to confidential object - #44360

Merged
miaulalala merged 1 commit into
masterfrom
fix/add-exdate-exrule-to-confidential-object
Mar 21, 2024
Merged

fix(caldav): add EXDATE and EXRULE to confidential object#44360
miaulalala merged 1 commit into
masterfrom
fix/add-exdate-exrule-to-confidential-object

Conversation

@miaulalala

@miaulalalamiaulalala commented Mar 20, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

The EXDATE / EXRULE properties are lost when a confidential object is created.

Checklist

@miaulalalamiaulalala added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Mar 20, 2024
@miaulalalamiaulalala added this to the Nextcloud 29 milestone Mar 20, 2024
@miaulalala
miaulalala requested a review from st3inyMarch 20, 2024 14:24
@miaulalalamiaulalala self-assigned this Mar 20, 2024
@miaulalala

miaulalala commented Mar 20, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable28

@miaulalala

miaulalala commented Mar 20, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@miaulalala

miaulalala commented Mar 20, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@AltahrimAltahrim mentioned this pull request Mar 20, 2024
Merged
tcitworld
tcitworld approved these changes Mar 20, 2024
View reviewed changes

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense

tcitworld
tcitworld reviewed Mar 20, 2024
View reviewed changes
Comment threadapps/dav/lib/CalDAV/CalendarObject.php
@miaulalala
miaulalalaforce-pushed the fix/add-exdate-exrule-to-confidential-object branch from 2c2165c to 9999f15CompareMarch 20, 2024 17:33
@miaulalala
fix(caldav): add EXDATE and EXRULE to confidential object
a96f8f7
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalalaforce-pushed the fix/add-exdate-exrule-to-confidential-object branch from 9999f15 to a96f8f7CompareMarch 21, 2024 09:01
@miaulalala
miaulalala enabled auto-merge March 21, 2024 11:45
@miaulalala
miaulalala merged commit bdd4ac2 into masterMar 21, 2024
@miaulalala
miaulalala deleted the fix/add-exdate-exrule-to-confidential-object branch March 21, 2024 13:34
This was referenced Mar 21, 2024
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcitworldtcitworldtcitworld approved these changes
@kesselbkesselbkesselb approved these changes
@st3inyst3inyAwaiting requested review from st3iny
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurstChristophWurst is a code owner

Assignees

@miaulalalamiaulalala

Labels

3. to reviewWaiting for reviewsbugfeature: caldavRelated to CalDAV internals

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Removed Single Occurrence of Reoccurring, Confidential Event Remains on Shared Calendar

3 participants

@miaulalala@tcitworld@kesselb